Editor: Avoid triggering the start page modal on unsaved pages#61082
Merged
Conversation
youknowriad
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Apr 25, 2024
Member
richtabor
left a comment
richtabor
left a comment
There was a problem hiding this comment.
Works as expected.
CleanShot.2024-04-25.at.09.39.31.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug raised here #60745 (comment)
What?
When we create a new page in the site editor, we're shown a modal to pick a starter content. If we pick some content and immediately navigate out of the page in the site editor with the unsaved changes, when we come back to the page, it was still considered "empty" which cause the modal to appear again even if the page was not really empty.
How?
It turns out that
editEntityRecod( { blocks } )is not enough to change the return value of the over optimizedisEmptyEditedPost. It seems that every time we call editEntityRecord with blocks, we're supposed to also call it with a function edit for the "content" to ensure that the save mechanism knows how to persist the blocks into content on save.Testing Instructions
1- Create a new page in the site editor
2- Choose a starter content in the modal
3- Click the site icon to leave the editor page
4- Click the preview frame again to go back to the editor
5- You shouldn't see the starter options modal again.