Grid interactivity: Improve max attribute logic#61420
Merged
Merged
Conversation
noisysocks
added
the
[Feature] Layout
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +26 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 37d0ef3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8980246534
|
tellthemachines
approved these changes
May 7, 2024
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is a good little improvement and works well in testing.
noisysocks
changed the title
max attribute logicmax attribute logic
noisysocks
removed
the
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Small fix that I've split out of #59490.
Improves the logic that sets the
maxattribute in the Grid placement input controls. These are currently behind an experimental flag and I doubt they'll ship in WP 6.6.Why?
In a grid that's in manual mode (i.e. it has a column and row count), the user shouldn't be able to set the row or column placement to be such that it would extend past the boundary of the grid.
How?
This makes
maxtake into account the Grid block's number of columns/rows and the item's span.Testing Instructions