Grid interactivity: Show grid visualizer when block inspector is closed#61429
Merged
noisysocks merged 2 commits intoMay 13, 2024
Merged
Conversation
noisysocks
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
noisysocks
removed
the
[Type] Bug
|
Size Change: +15 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
reviewed
May 8, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Nice simple fix 👍
This is mostly testing nicely for me, with one exception, which is when distraction free mode is activated:
On trunk, in distraction free mode, the visualiser is never displayed because the inspector controls are closed. With this PR applied, if you mouse over the top of the window, the toolbar becomes visible, and in this case, the visualiser is displayed in the wrong position:
2024-05-08.10.49.36.mp4
Would it be worth either a) checking for distraction free mode and if it's switched on, then hide the visualizer (I think that's probably what I'd expect), or b) see if it's possible to fix the positioning?
Otherwise this was testing well for me in the usual expected situations:
2024-05-08.10.46.21.mp4
Member
Author
That's a great idea, done 👍 |
andrewserong
approved these changes
May 9, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for the update, that's testing well for me now, with the visualizer hidden when distraction free mode is switched on 👍
LGTM! 🚀
noisysocks
force-pushed
the
fix/show-grid-visualiser-when-inspector-is-closed
branch
from
cd4ce81 to
9c11c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Small fix that I've split out of #59490.
Why?
In
trunkthe grid visualiser will go away when you close the block inspector. That's not right!How?
Render the visualiser in the layout's
toolbarControls, notinspectorControls.Testing Instructions
Screenshots or screencast