Background images: remove lingering "file" prop#61469
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
left a comment
There was a problem hiding this comment.
Good catch!
✅ site wide background images are still output in the post and site editors
✅ site wide background images are still output on the site front end
✅ if I manually add a source key to the backgroundImage object, it doesn't affect anything (just in case anyone already has a key added there)
LGTM! 🎉
What?
This PR is a follow up to #61387 - I missed a reference to source in the theme json class in
INDIRECT_PROPERTIES_METADATA. Whoops!The changes were first added in #59454.
The deleted line is not yet in Core, and the changes are already reflected in the latest 6.6 backport PR:
Why?
Janitorial
How?
DELETE
Testing Instructions
The CI tests should pass.
If you're feeling up to it, you could test that there are no regressions to site wide background images in the side editor/frontend.
Here is some test json!