Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
added
[Type] Bug
|
Size Change: +54 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
annezazu
added
the
Global Styles
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for the ping to review @scruffian 👍
This PR highlighted some code that was missed in the recent efforts to switch shared variations from styles.blocks.variations to styles.variations.
Those changes landed yesterday in #62712. The result is that the useResolvedBlockStyleVariationsConfig has no effect and isn't required anymore. I've created a PR to remove that hook entirely in #62808.
On trunk I can't replicate the original issue so I think we might be able to close both the issue and this PR.
Screen.Recording.2024-06-25.at.12.07.55.PM.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62758.
This processes style variation previews in the same way that we process variations when they are committed so that they are formatted the same way and can be detected as the same.
Why?
This is necessary so that style variations are marked as active:
How?
Process the style variation with
useResolvedBlockStyleVariationsConfigbefore comparing it to the saved user variation.There are some other possibilities for how to solve this:
useResolvedBlockStyleVariationsConfigcall to insideareGlobalStyleConfigsEqualso that other uses of this function benefit from the change.useResolvedBlockStyleVariationsConfigup the call stack so that the variation is processed before this point.Testing Instructions
Screenshots or screencast