Add SizeControl component#62866
Draft
matiasbenedetto wants to merge 1 commit into
Draft
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
the
[Feature] UI Components
Closed
Member
|
Related (?): #61180 |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Provide a new UI component to define a size.
This PR extracts a part of the FontSizePicker controller and makes it a new independent controller that can be used inside the FontSizePicker controller and as a stand-alone controller.
Why?
The new SizeControl provides an agnostic UI to define a size that could be used to define not only font sizes but spacings and probably other settings.
Most of the SizeControl component UI and logic already exist inside the FontSizePicker control, making it impossible to reuse them outside of it.
This component could be used in the implementation of these two interfaces:
How?
Extracting the UI and logic from FontSizePicker and making it a stand-alone component, simplifying the logic where possible.
Testing Instructions
Screenshots or screencast
See screencasts of the component in use in #62328