Block styles variations E2E: wait for Save button before editing global styles#62915
Merged
Merged
Conversation
…in the useSelect store subscription callback
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -339 B (-0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jun 27, 2024
ramonjd
added
[Type] Automated Testing
ramonjd
changed the title
andrewserong
approved these changes
Jun 28, 2024
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Looks good to me! 🚀
| } ); | ||
| // The save button has been re-enabled. | ||
|
|
||
| // Wait for the save button to be re-enabled. |
Contributor
There was a problem hiding this comment.
No blockers here, just making sure I understand the change here:
This change is now checking that that Save is visible, rather than enabled. From looking at the editor manually, while saving, the button says "Saving" rather than "Save", so .toBeVisible() is a good check to use, as it'll only pass if the button says "Save" rather than "Saving". Also, once the revision has been saved the button is in a disabled state, so toBeVisible is a more reliable check than toBeEnabled.
Assuming that's all how it's meant to be, that sounds great to me!
Member
Author
There was a problem hiding this comment.
Exactly what you said, thanks for confirming.
Much better expressed than what my caveman brain was thinking: "Wait for save. Save there. Good save."
gutenbergplugin
pushed a commit
that referenced
this pull request
Jun 28, 2024
…al styles (#62915) * Add blockName to the overrides array so getBlockName() can be called in the useSelect store subscription callback * Update e2e test to wait for save button between styles updates * Revert selector name Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
github-actions
Bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: c6bc947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and how?
Follow up to:
Tweak the E2E test to wait for the Save button to be visible between global styles saves. 🤞🏻 it'll make it less flakey.
Should be backported to wp/6.6 branch because the original tests are also there.
Testing Instructions
E2E CI tests should pass.