Block Pattern Setup: do not use Composite store#65039
Merged
ciampo merged 1 commit intoSep 4, 2024
Merged
Conversation
|
Size Change: -21 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
ciampo
added
[Package] Block editor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Sep 4, 2024
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM, tests as before with Jetpack (tested with Form and the Payments blocks) 👍
ciampo
deleted the
feat/stabilize-composite/no-store/block-pattern-setup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #64723
Do not use Composite's store directly in Block Pattern Setup
Why?
See #63704 (comment)
How?
We recently made changes so that:
Compositecomponent accepts the same props asuseCompositeStore;Compositesubcomponents already receive the correctstorewithout need for the consumer to pass it explicitlyTherefore, we can migrate from
to
Testing Instructions
This component is not used in the editor anymore, but you can follow testing instructions from #55425 on how to test it with an external plugin.