.screen-reader-text CSS update for a11y add-container.js#66136
Closed
colorful-tones wants to merge 1 commit into
Closed
.screen-reader-text CSS update for a11y add-container.js#66136colorful-tones wants to merge 1 commit into
colorful-tones wants to merge 1 commit into
Conversation
Addresses part of #65954
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
colorful-tones
added
the
[Focus] Accessibility (a11y)
colorful-tones
added
the
[Type] Code Quality
colorful-tones
deleted the
update/screen-reader-text-css-add-container
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #65954
Why?
The utility
.screen-reader-textCSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.How?
Remove the unnecessary
clip: rect(1px, 1px, 1px, 1px);and-webkit-clip-path: inset(50%);rules from thepackages/a11y/src/script/add-container.jsStyle attribute