Skip to content

Remove clip and -webkit-clip for block-library common.scss#66144

Merged
afercia merged 1 commit into
WordPress:trunkfrom
mediaformat:update/screen-reader-css-common-scss
Oct 16, 2024
Merged

Remove clip and -webkit-clip for block-library common.scss#66144
afercia merged 1 commit into
WordPress:trunkfrom
mediaformat:update/screen-reader-css-common-scss

Conversation

@mediaformat
Copy link
Copy Markdown
Contributor

@mediaformat mediaformat commented Oct 15, 2024

What?

Addresses part of #65954

Why?

The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.

How?

Remove the unnecessary clip: rect(1px, 1px, 1px, 1px); and -webkit-clip-path: inset(50%); rules from the packages/block-library/src/common.scss

Style attribute

Before After
Screenshot 2024-09-17 at 17 48 21 Screenshot 2024-09-17 at 17 48 57

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mediaformat <mediaformat@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 15, 2024
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mediaformat! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@colorful-tones colorful-tones added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality labels Oct 15, 2024
@mediaformat mediaformat changed the title Remove clip and -webkit-clip for screen-reader-text CSS Remove clip and -webkit-clip for block-library common.scss Oct 15, 2024
Copy link
Copy Markdown
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me

@afercia afercia merged commit 6544c6f into WordPress:trunk Oct 16, 2024
@github-actions github-actions Bot added this to the Gutenberg 19.5 milestone Oct 16, 2024
@mediaformat mediaformat deleted the update/screen-reader-css-common-scss branch October 16, 2024 15:33
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
)


Co-authored-by: mediaformat <mediaformat@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants