Remove clip & -webkit-clip-path for downloadable-block-list-item style.scss#66147
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mediaformat! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks @mediaformat
|
afercia
left a comment
There was a problem hiding this comment.
I'd suggest to replace the entire rule with a display: none.
|
@afercia I see what you mean. I'll replace the entire rule with |
Great catch and thanks @afercia ! I tested with |
…e.scss (WordPress#66147) * Remove clip for screen-reader-text CSS * item__author display none while is-installing Co-authored-by: mediaformat <mediaformat@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>


What?
Addresses part of #65954
Why?
The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.
How?
Remove the unnecessary clip: rect(1px, 1px, 1px, 1px); and -webkit-clip-path: inset(50%); rules from the packages/block-library/src/components/downloadable-block-list-item/style.scss
Style attribute