Button: Suppress __next40pxDefaultSize warning if the variant is link#71689
Closed
shrivastavanolo wants to merge 2 commits into
Closed
Button: Suppress __next40pxDefaultSize warning if the variant is link#71689shrivastavanolo wants to merge 2 commits into
shrivastavanolo wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Code Quality
Contributor
Author
|
Converting the PR to draft till unit tests are fixed. Will reopen shortly. |
shrivastavanolo
force-pushed
the
fix/lint-warning-for-button-link-variant
branch
from
a92b869 to
9b7f183
Compare
Contributor
Author
|
This PR is ready for review now! Also, please let me know if a changelog entry is required for this (imo this was a minor change hence I did not add it) |
Member
|
Closing in favor of #74622. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71683
Suppresses the
__next40pxDefaultSizeESLint warning when the Buttonvariant is
link.Why?
Link variant Buttons don’t use a fixed height. The
__next40pxDefaultSizeprop and related class are not meaningful for this case, so they should
not trigger warnings or extra styles.
How?
variant="link".