Fix: Prevent custom links from creating empty block bindings#72134
Merged
Conversation
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Ideally we'd have added tests here but given this is a nasty bug let's just test and merge and then follow up to add coverage. |
jeryj
reviewed
Oct 7, 2025
Contributor
jeryj
left a comment
jeryj
left a comment
There was a problem hiding this comment.
Tested manually with custom links and pages and they are now correctly bound
getdave
commented
Oct 7, 2025
|
Size Change: +15 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Contributor
Author
|
@jeryj If/when this is ready I'd appreciate you hitting merge so we can land asap 🙏 |
jeryj
approved these changes
Oct 7, 2025
|
Flaky tests detected in 768c2ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18317153635
|
getdave
added
the
Backport to Gutenberg RC
Contributor
Author
|
@cbravobernal This one fixes a bug in the other PR which you are including in RC |
cbravobernal
pushed a commit
that referenced
this pull request
Oct 8, 2025
* Fully clear binding when clearing * Go with a simpler approach * Simplify even further * Add test coverage * Add tests for conditional clearBinding and optimize test performance * Fix check for specific binding source Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the release/21.8 branch to get it included in the next release: 423ff3c |
cbravobernal
removed
the
Backport to Gutenberg RC
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…ss#72134) * Fully clear binding when clearing * Go with a simpler approach * Simplify even further * Add test coverage * Add tests for conditional clearBinding and optimize test performance * Fix check for specific binding source Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug introduced in #71630 where custom links (static URLs like
www.google.com) were incorrectly getting block binding metadata created, even though they should only be plain static links without any bindings.Why
In #71630, we introduced block bindings for Navigation Link blocks to make entity links (Pages, Posts, etc.) dynamic. However, there was a bug in the implementation:
The Problem:
When creating a custom link by typing a URL directly (e.g.,
www.google.com), the system was callingclearBinding()even though there was never a binding in the first place. This resulted in unnecessary binding metadata being added:Root Cause:
clearBinding()always calledupdateBlockBindings(), regardless of whether a valid binding existed. This polluted the block markup with unnecessary metadata and could potentially cause issues with block validation and rendering.How
Updated the
useEntityBindinghook to add a conditional check before clearing bindings:This ensures we only perform the clear operation when there's an actual binding with a valid source, preventing unnecessary metadata from being created.
Testing
Test Case 1: Custom Link Creation
www.google.commetadataattribute should appear on the block"metadata":{"bindings":{"url":{"source":null,"args":null}}}Test Case 2: Entity Link Creation
"metadata":{"bindings":{"url":{"source":"core/entity","args":{"key":"url"}}}}Test Case 3: Entity Link to Custom Link
Test Case 4: Existing Blocks
Screenshots
N/A - This is a data/markup fix with no visual changes