Update Edit control for template field#75518
Closed
oandregal wants to merge 6 commits into
Closed
Conversation
github-actions
Bot
added
[Package] Edit Site
oandregal
added
[Type] Enhancement
oandregal
commented
Feb 13, 2026
|
Size Change: -446 B (-0.01%) Total Size: 3.03 MB
ℹ️ View Unchanged
|
Closed
oandregal
force-pushed
the
update/template-field-select
branch
from
5dc4e6e to
75f46ec
Compare
github-actions
Bot
added
[Package] Edit Site
Member
Author
I've implemented this at 75f46ec Note this works like the editor inspector: if the page is set as the "posts page" template, users cannot change the template. Any other case (including the page that is set as homepage) can change the template. For reference, in trunk, QuickEdit added an extra restriction to prevent the pages set as homepage to change its template. Not sure why that is, but wanted to brought it up.
|
oandregal
commented
Feb 13, 2026
Comment on lines
+65
to
+74
| // TODO: this template id is computed differently than the templateId in the editor inspector | ||
| // Compare with | ||
| // https://github.com/WordPress/gutenberg/blob/8c2a7c775f5b5fb19d8dca66a09d18977cf42b7d/packages/editor/src/components/post-template/panel.js#L21 | ||
| // The editor inspector computes it from the editor store (that we cannot use in this package), | ||
| // that ends up being using the getTemplateId private selector from core data. | ||
| const templateId = await resolveSelect( | ||
| coreDataStore | ||
| ).getDefaultTemplateId( { | ||
| slug: slugToCheck, | ||
| } ); |
Member
Author
There was a problem hiding this comment.
This has ported the existing logic from template-edit and in doing so it raised a bug: the templateId computed here is different from the one computed in the editor inspector (which ends up using the private selector getTemplateId). As a result, the template for the posts page is "Pages" and not "Blog post".
Member
Author
|
In discussing this PR with @ntsekouras he raised some questions about introducing the item param to getElements. We also considered related problems (e.g., fields whose elements depend on other field's values – such as a country/region relationship) where we'd benefit from having access to the data as well. Given the tight timeline, I've prepared #75565 that does not modify any API, and enables us to fix the issue with the template field (which is blocking QuickEdit from becoming stable). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #75421
Follow-up to #75290
What?
This PR updates the template edit component to rely on the field elements. In doing so, it also updates the rendered value of the template in DataViews.
Why?
The template field was rendered as a regular field with a custom button, but that interaction and the visuals are at odds with the new trigger mechanism for the panel introduced at #75290. That's the primary aspect this PR is trying to solve.
Additionally, as a bonus, by leveraging the field elements, this PR displays the template name in the DataViews layout.
How?
itemas a new parameter togetElements, so fields can calculate elements based on the data.Testing Instructions
Visit the Site Editor's Pages screen, and interact with the template field. Verify that it's always displaying the proper value of the template (e.g., go to the pages editor and compare with the value there).
TODO
2. Make the template not editable if the page is set as the "blog page", like in the editor inspector.Fix #75518 (comment)There was some logic to making the page not editable if it was the homepage as well, but the editor inspector allows users to change it — so there's no reason for QuickEdit not to. wp-admin allows editing the template for both.
Edit the template of the posts page:
Screen.Recording.2026-02-13.at.14.13.03.mov
Edit the template of the homepage:
Screen.Recording.2026-02-13.at.14.12.39.mov
Edit the templates for the posts page & homepage via wp-admin:
Screen.Recording.2026-02-13.at.14.12.11.mov