Block Bindings: Expose featuredMedia information from core/post-data source#75625
Draft
ockham wants to merge 9 commits into
Draft
Block Bindings: Expose featuredMedia information from core/post-data source#75625ockham wants to merge 9 commits into
featuredMedia information from core/post-data source#75625ockham wants to merge 9 commits into
Conversation
ockham
added
[Type] Enhancement
ockham
changed the title
featuredMedia information from core/post-data source
|
Size Change: +57 B (0%) Total Size: 6.85 MB
ℹ️ View Unchanged
|
13 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
WIP, spun off from #74610.
Add two new fields,
featured_media.idandfeatured_media.url(which reflect the given post's featured image) to thecore/post-datasource.Why?
Essentially, to introduce a syntax that supports composite data types in block bindings, e.g.
{ "metadata": { "bindings": { "id": { "source": "core/post-data", "args": { "field": "featured_media.id" } }, "href": { "source": "core/post-data", "args": { "field": "featured_media.url" } } } } }How?
(By simply adding those new fields to the existing Block Bindings source.)
Testing Instructions
Verify that it's possible to bind an Image block's
urlandidattributes to the newly addedcore/post-datafields, and that the block then correctly shows the post's featured image (both in the editor and on the frontend).TODO
featured_mediatofeaturedMedia?core/post-datasource for the Date block. Needs a different solution now.Screenshots or screencast