Skip to content

Revert client-side media processing plugin-only gate#76751

Merged
adamsilverstein merged 2 commits into
trunkfrom
revert-csm-plugin-only
May 28, 2026
Merged

Revert client-side media processing plugin-only gate#76751
adamsilverstein merged 2 commits into
trunkfrom
revert-csm-plugin-only

Conversation

@adamsilverstein
Copy link
Copy Markdown
Member

@adamsilverstein adamsilverstein commented Mar 21, 2026

Summary

Once we fork WordPress 7.1, I plan to re-introduce the client side media feature. This PR restores core support in the plugin code path.

This reverts commit d259aab.

Test plan

  • Verify client-side media processing works in both the plugin and core contexts
  • Confirm the VIPS loader script module is enqueued without the IS_GUTENBERG_PLUGIN check
  • Confirm lib/media/load.php no longer early-returns for non-plugin contexts

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 21, 2026

Flaky tests detected in 93e4a66.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26188534208
📝 Reported issues:

@adamsilverstein adamsilverstein added [Status] In Progress Tracking issues with work in progress [Type] Feature New feature to highlight in changelogs. [Feature] Client Side Media Media processing in the browser with WASM No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core labels Mar 22, 2026
@adamsilverstein
Copy link
Copy Markdown
Member Author

7.1 is now open for commits, see https://make.wordpress.org/core/2026/05/20/commence-operation-wp-7-1/

@adamsilverstein
Copy link
Copy Markdown
Member Author

I'm planning to reintroduce Client-side media in core in WordPress/wordpress-develop#11324. Once I do that we can merge this PR.

@adamsilverstein adamsilverstein merged commit 0a801ac into trunk May 28, 2026
41 checks passed
@adamsilverstein adamsilverstein deleted the revert-csm-plugin-only branch May 28, 2026 15:44
@github-actions github-actions Bot added this to the Gutenberg 23.4 milestone May 28, 2026
@alecgeatches
Copy link
Copy Markdown
Contributor

alecgeatches commented May 28, 2026

I think I'm seeing some failed tests from trunk related to this PR:

1) Media_Processing_Test::test_get_rest_index_should_return_additional_settings_can_upload_files
Failed asserting that an array does not have the key 'image_output_formats'.

The first trunk failed test run here: https://github.com/WordPress/gutenberg/actions/runs/26585389684/job/78330386114 from the same commit 0a801ac merged above.

@adamsilverstein
Copy link
Copy Markdown
Member Author

I think I'm seeing some failed tests from trunk related to this PR:

1) Media_Processing_Test::test_get_rest_index_should_return_additional_settings_can_upload_files
Failed asserting that an array does not have the key 'image_output_formats'.

The first trunk failed test run here: https://github.com/WordPress/gutenberg/actions/runs/26585389684/job/78330386114 from the same commit 0a801ac merged above.

Thanks, I'll take a look.

@adamsilverstein
Copy link
Copy Markdown
Member Author

@alecgeatches - see #78788 - we can disable or remove the tests for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Client Side Media Media processing in the browser with WASM No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Status] In Progress Tracking issues with work in progress [Type] Feature New feature to highlight in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants