Admin UI: use UI Text component in header#77372
Merged
Merged
Conversation
|
Size Change: +1.19 kB (+0.02%) Total Size: 7.82 MB 📦 View Changed
ℹ️ View Unchanged
|
simison
force-pushed
the
update/admin-ui-header-text
branch
from
ec81749 to
cfdd827
Compare
Member
Author
|
@mirka @ciampo @aduth FYI I'm still seeing 
|
simison
commented
Apr 15, 2026
| z-index: 1; | ||
| } | ||
|
|
||
| // @TODO: Remove truncation styles once `Text` supports truncation natively. |
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Nit: we could leave a link to #77391 in the code comment here, and everywhere applicable.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 07dd496. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25048062184
|
Member
We're currently only injecting heading defense styles when the variant is gutenberg/packages/ui/src/text/text.tsx Line 23 in 7991839 |
Member
Author
It was just for styling reasons; I was copying what was in the breadcrumbs PR, but actually, now I see we have a mix of body-lg and heading-lg there. Switching to heading in 9f31f7a Heading is a bit heavier, but assuming it's ok. FYI @jameskoster |
Contributor
|
Right, |
Member
|
I've also addressed it at the component level in #77461. |
Contributor
|
With the latest changes, things are looking good to me 
|
ciampo
approved these changes
Apr 21, 2026
| z-index: 1; | ||
| } | ||
|
|
||
| // @TODO: Remove truncation styles once `Text` supports truncation natively. |
Contributor
There was a problem hiding this comment.
Nit: we could leave a link to #77391 in the code comment here, and everywhere applicable.
simison
force-pushed
the
update/admin-ui-header-text
branch
from
9f31f7a to
07dd496
Compare
t-hamano
pushed a commit
that referenced
this pull request
Apr 29, 2026
* Admin UI: use UI Text component in header * Correct size * Update CHANGELOG.md * Remove unneeded margin reset * Add todo * Use heading-lg instead of body-lg * Update todo with a link --- Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
TextUI component directly instead of design tokens via CSS.typography-*styles and margin reset, which also isn't needed now.How?
Testing Instructions
You should not notice any visual differences.
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools