Skip to content

Fix: Accessibility issues in admin Font Library #77482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 1 commit into from
Apr 20, 2026
Merged

Fix: Accessibility issues in admin Font Library #77482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routes/font-list/stage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function FontLibraryPage() {
}

return (
<Page title={ __( 'Fonts' ) }>
<Page headingLevel={ 1 } title={ __( 'Fonts' ) }>
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an e2e assertion that the page “Fonts” heading is exposed as level 1 (e.g., role="heading" with level 1). This change is specifically accessibility-related and could regress back to the default headingLevel (2) without a targeted test.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an e2e test is redundant.

<Tabs
selectedTabId={ activeTab }
onSelect={ ( tabId: string ) => setActiveTab( tabId ) }
Expand Down
Loading