Upgrade and unify @types/node version#77900
Merged
Merged
Conversation
manzoorwanijk
requested review from
a team,
kevin940726,
nerrad and
ntwb
as code owners
manzoorwanijk
added
[Type] Code Quality
github-actions
Bot
added
[Package] Core data
manzoorwanijk
force-pushed
the
update/upgrade-and-unify-node-types-version
branch
from
d4d06c4 to
6e5fb4d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.87 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8bf7358. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25312269514
|
manzoorwanijk
force-pushed
the
update/upgrade-and-unify-node-types-version
branch
2 times, most recently
from
c66eb63 to
18462a5
Compare
manzoorwanijk
force-pushed
the
update/upgrade-and-unify-node-types-version
branch
from
18462a5 to
403bd63
Compare
Member
Is there a need to move this to the latest 20.x version? It does seem good to be consistent with the version used across the Gutenberg repository, but it doesn't seem necessary to require consumers to use the latest 20.x node version. In fact, this seems like it may encourage this duplication in consumers who are not very careful to avoid it by forcing a package upgrade that isn't essential. It seems preferable to relax and widen the declared dependency. Consistency is good, but perhaps It does seem valuable to update this package in our lockfile to the latest 20.x version and ensure that it is not duplicated there. |
Member
Author
Good catch. Thanks. I will revert the change for e2e utils peer-dependency. |
Add @types/node to devDependencies for local type support in packages/e2e-test-utils-playwright, and relax/pin the peerDependency for @types/node to ^20.17.10 to maintain compatibility with downstream consumers.
Member
Author
|
Updated. Thanks |
Member
|
All the package.json files are still upgrading the dependency. My comment was that they should align, but not necessarily upgrade to the latest version. I still see this in the diff: -"@types/node": "^20.19.0",
+"@types/node": "^20.19.39",I think these could either all target the previous minimum version range -"@types/node": "^20.19.0",
+"@types/node": "^20.17.10",or -"@types/node": "^20.17.10",
+"@types/node": "^20.19.0", |
Member
Author
But those are all |
Member
My mistake, you're right, thanks. |
sirreal
approved these changes
May 4, 2026
Member
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
Looks good, nice cleanup. Having duplicated types versions like this can be problematic so thanks for addressing it.
Contributor
|
I'm not an expert of Would there be value in such a check? |
Member
Author
There is a very popular tool for that - Syncpack. We could set it up with some rules to ensure we have consistency across the monorepo. |
Member
Author
|
I have created #77950 to add Syncpack to ensure the dependencies are consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrade and unify the
@types/nodeversion across all workspaces, and add the dependency to workspaces that were missing it.Extracted out of #75814.
Why?
The
@types/nodeversion was inconsistent across the repo:^20.17.10packages/core-datawas on^20.19.0test/e2e,test/storybook-playwright, etc.) were missing the dependency entirely, relying on whatever version got hoistedInconsistent versions across workspaces can result in multiple copies of
@types/nodebeing installed, which leads to type conflicts (e.g. duplicated/incompatible Node global declarations) and unpredictable type-checking behavior depending on hoisting order.How?
@types/nodeentry to^20.19.39(latest in the20.xline), including the rootpackage.json@types/node: ^20.19.39as adevDependencytotest/e2eandtest/storybook-playwright, which were previously missing itpackage-lock.jsonaccordinglyNo production code changes —
devDependency/peerDependencyupdates only.Testing Instructions
npm run clean:package-types && npm run buildTesting Instructions for Keyboard
N/A — no UI changes.
Screenshots or screencast
N/A — dependency-only change.
Use of AI Tools
The PR description was drafted with assistance from Claude Code.