Add layout and block spacing support to Latest Posts block#77989
Open
tellthemachines wants to merge 5 commits into
Open
Add layout and block spacing support to Latest Posts block#77989tellthemachines wants to merge 5 commits into
tellthemachines wants to merge 5 commits into
Conversation
tellthemachines
added
[Type] Enhancement
|
Size Change: +587 B (+0.01%) Total Size: 7.98 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 601548d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26207163167
|
tellthemachines
force-pushed
the
add/latest-posts-layout-support
branch
from
bb4677d to
92b61a7
Compare
tellthemachines
commented
May 18, 2026
| 'string' !== typeof oldAttributes.categories | ||
| ) { | ||
| return oldAttributes; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
had to add this check because we need to run this before the layout migration, and if we don't check whether categories actually exists it just goes and adds an array of them anyway
tellthemachines
commented
May 18, 2026
| ! postCount | ||
| ? MAX_POSTS_COLUMNS | ||
| : Math.min( MAX_POSTS_COLUMNS, postCount ) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Removing the old max here so it matches the Post Template controls.
tellthemachines
commented
May 18, 2026
| [ `columns-${ columns }` ]: postLayout === 'grid', | ||
| [ `columns-${ columnCount }` ]: | ||
| layoutType === 'grid' && columnCount, | ||
| 'has-native-responsive-grid': |
Contributor
Author
There was a problem hiding this comment.
This block has the same responsive fallback as Post Template so we're adding the same back compat workaround.
tellthemachines
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
reviewed
May 20, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
It took me way too long to realize I had to click on the "grid" layout to test 🤦🏻
Question: does this make the existing postLayout and columns attributes in block.json deprecated? Do they stay there for any reason? (Assuming backwards compat)
| ...attributesWithoutLegacyLayout, | ||
| layout: { | ||
| type: postLayout === 'grid' ? 'grid' : 'default', | ||
| ...( postLayout === 'grid' && columns && { columnCount: columns } ), |
Member
There was a problem hiding this comment.
Does there need to be a default here, or does it flow down from block.json? (column: 3)
E.g., columnCount: columns ?? 3
Contributor
Author
There was a problem hiding this comment.
It'll be whatever is set on the legacy block, which might be that default from block.json or something else if user has changed it.
Contributor
Author
There was a problem hiding this comment.
ah actually I think we should ensure the legacy attribs are present in the deprecation, then they can be removed from the block.json
| }, | ||
| migrate: ( oldAttributes ) => | ||
| migratePostLayout( migrateCategories( oldAttributes ) ), | ||
| isEligible: ( { postLayout } ) => postLayout, |
Member
There was a problem hiding this comment.
Does the migration have to run just for 'grid' or all layouts?
Contributor
Author
There was a problem hiding this comment.
all layouts because we're also converting the "list" layout to the "default" type.
| html: false, | ||
| }, | ||
| migrate: migrateCategories, | ||
| isEligible: ( { categories } ) => |
Member
There was a problem hiding this comment.
Apologies, I haven't had my nose in deprecations for a long time.
Does this deprecation see the original raw attributes or the already-migrated attributes?
Just wondering if this will run on the original attributes and replace the migration result from before. If so maybe a ! postLayout check would stop that?
I don't know! 😄
Contributor
Author
There was a problem hiding this comment.
As I understand it the migrations always run in sequence, so if the block is eligible for the categories migration it'll run that, and if it's eligible for the layout one it'll run categories and then layout on whatever categories spat out. I tested this on blocks with legacy layouts and it seemed to work fine.
Contributor
Author
sorry, I didn't think to add that step explicitly 😅
Oh I think they can be removed! Looking at #49050 as an example, we removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Similar to #49050 and #77411.
Adds layout and block spacing support to Latest Posts to replace its custom list/grid styles.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
(note that Layout panel is now in the Styles tab)
Use of AI Tools
Written by GPT 5.5.
leaving as a draft until I've reviewed it properly.this has now been human-reviewed.