Skip to content

Connectors: backport changes in core#78103

Merged
t-hamano merged 1 commit into
trunkfrom
connectors-plugin-install-check-phpstan
May 9, 2026
Merged

Connectors: backport changes in core#78103
t-hamano merged 1 commit into
trunkfrom
connectors-plugin-install-check-phpstan

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented May 8, 2026

What?

Backports WordPress core WordPress/wordpress-develop#11701 to Gutenberg.

Why?

Core tightened the PHPStan type shapes for the Connectors API, so Gutenberg's mirror implementation needs to stay in sync.

Testing Instructions

Behavior is unchanged, so verifying that the existing Connectors functionality is not broken is sufficient.

Use of AI Tools

This pull request was authored with Claude Code. Code review is performed by a human.

Backport WordPress core PR WordPress/wordpress-develop#11701
to keep Gutenberg's connectors API in sync. PHPStan-only docblock refinements,
plus the supporting body changes the tightened types require: always populate
the AI provider auth/plugin defaults so the stored Connector shape matches the
type, and guard `get_option()` results with `is_string()`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@t-hamano t-hamano changed the title Connectors: Refine PHPStan type shapes Connectors: backport changes in core May 8, 2026
@t-hamano t-hamano self-assigned this May 8, 2026
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Feature] Connectors screen Tracks connectors screen related tasks labels May 8, 2026
@t-hamano t-hamano marked this pull request as ready for review May 8, 2026 15:49
@t-hamano t-hamano requested a review from spacedmonkey as a code owner May 8, 2026 15:49
@t-hamano t-hamano requested a review from westonruter May 8, 2026 15:49
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano merged commit 6aa5ea1 into trunk May 9, 2026
58 of 61 checks passed
@t-hamano t-hamano deleted the connectors-plugin-install-check-phpstan branch May 9, 2026 09:53
@github-actions github-actions Bot added this to the Gutenberg 23.2 milestone May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Connectors screen Tracks connectors screen related tasks No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants