[WP/7.0] Connectors: Replace @wordpress/ui Link and Notice usage#78117
Conversation
|
Please note that the following CI will never succeed here because the build itself fails on the wp/7.0 branch. Regarding the E2E test failures, this PR is not the cause, so further investigation is required separately. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cef3da8 to
1a5a662
Compare
This should be fixed in #78160 |
The `Link` and `Notice` components from `@wordpress/ui` are not yet built on the current branch, so importing them prevents the connectors-home route from running. Swap `Link` for `ExternalLink` from `@wordpress/components`, and reproduce the `Notice` (info intent) with inline HTML/CSS based on the upstream `@wordpress/ui` Notice implementation. The replacement preserves the screen reader announcement via `speak()` to keep accessibility parity. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1a5a662 to
97e5821
Compare
| scroll-margin-top: $sticky-header-clearance; | ||
| } | ||
|
|
||
| &__file-mods-notice { |
There was a problem hiding this comment.
Would it be simpler to bring over the code for the Notice component, or are there complications? @wordpress/ui is a bundled package, so it shouldn't affect anything else.
There was a problem hiding this comment.
I tried using the Notice component with dbe1d35, but it was a bit tricky.
- I migrated only the necessary sub-components, as bringing all of them would create a cascading increase in dependencies that would need to be moved or adjusted simultaneously.
- The defensive style is not available in wp/7.0.
- The design token names are slightly different.
Here are the differences between the Notice and Text components in wp7.0 and trunk:
Details
diff --git a/packages/ui/src/notice/index.ts b/packages/ui/src/notice/index.ts
index 0f093e10ea3..ca0f18fcab2 100644
--- a/packages/ui/src/notice/index.ts
+++ b/packages/ui/src/notice/index.ts
@@ -1,17 +1,4 @@
import { Root } from './root';
-import { Title } from './title';
import { Description } from './description';
-import { Actions } from './actions';
-import { CloseIcon } from './close-icon';
-import { ActionButton } from './action-button';
-import { ActionLink } from './action-link';
-export {
- Root,
- Title,
- Description,
- Actions,
- CloseIcon,
- ActionButton,
- ActionLink,
-};
+export { Root, Description };
diff --git a/packages/ui/src/notice/style.module.css b/packages/ui/src/notice/style.module.css
index 8d319cff874..56d44674d17 100644
--- a/packages/ui/src/notice/style.module.css
+++ b/packages/ui/src/notice/style.module.css
@@ -3,7 +3,7 @@
@layer wp-ui-components {
.notice {
--icon-height: 24px;
- --text-vertical-padding: calc((var(--icon-height) - var(--wpds-typography-line-height-sm)) / 2);
+ --text-vertical-padding: calc((var(--icon-height) - var(--wpds-font-line-height-sm)) / 2);
--wp-ui-notice-background-color: var(--wpds-color-bg-surface-neutral-weak);
--wp-ui-notice-border-color: var(--wpds-color-stroke-surface-neutral);
@@ -27,14 +27,6 @@
color: var(--wp-ui-notice-decorative-icon-color);
}
- .title {
- grid-column: 2;
-
- padding-block: var(--text-vertical-padding);
-
- color: var(--wp-ui-notice-text-color);
- }
-
.description {
grid-column: 2;
@@ -44,44 +36,6 @@
color: var(--wp-ui-notice-text-color);
}
- .actions {
- grid-column: 2;
-
- display: flex;
- gap: var(--wpds-dimension-gap-md);
- flex-wrap: wrap;
- }
-
- /* If .actions is not the only content, add top margin to match design specs */
- .notice:has(.title) .actions,
- .notice:has(.description) .actions {
- margin-block-start: var(--wpds-dimension-gap-sm);
- }
-
- .action-button {
- flex-shrink: 0;
- }
-
- .action-link {
- flex-shrink: 0;
-
- /* Add more horizontal space when following another action link/button */
- &:not(:first-child) {
- margin-inline-start: var(--wpds-dimension-gap-xs);
- }
-
- /* Add more horizontal space when followed by another action link/button */
- &:not(:last-child) {
- margin-inline-end: var(--wpds-dimension-gap-xs);
- }
- }
-
- .close-icon {
- grid-column: 3;
- grid-row: 1;
- margin-inline-start: var(--wpds-dimension-gap-xs);
- }
-
.is-info {
--wp-ui-notice-background-color: var(--wpds-color-bg-surface-info-weak);
--wp-ui-notice-border-color: var(--wpds-color-stroke-surface-info);
@@ -109,26 +63,4 @@
--wp-ui-notice-text-color: var(--wpds-color-fg-content-error);
--wp-ui-notice-decorative-icon-color: var(--wpds-color-fg-content-error-weak);
}
-
- /* Matches --wpds-dimension-surface-width-sm (container queries don't support custom properties). */
- @container (max-width: 320px) {
- .notice:has(.title) .description,
- .notice:has(.title) .actions {
- grid-column: 1 / 3;
- }
- }
-}
-
-@layer wp-ui-compositions {
- /* Override `Text` margin */
- .action-link {
- margin-block: auto;
- }
-
- /* Add partial transparency to CloseIcon and outline/minimal ActionButton
- * for a better look over tinted backgrounds */
- .close-icon,
- .action-button:is(.is-action-button-outline, .is-action-button-minimal) {
- --wp-ui-button-background-color-active: color-mix(in srgb, transparent 50%, var(--wpds-color-bg-interactive-neutral-weak-active));
- }
}
diff --git a/packages/ui/src/notice/types.ts b/packages/ui/src/notice/types.ts
index 11f938e3cc2..972579510e8 100644
--- a/packages/ui/src/notice/types.ts
+++ b/packages/ui/src/notice/types.ts
@@ -1,9 +1,6 @@
import type { ReactNode } from 'react';
import type { ComponentProps } from '../utils/types';
import type { IconProps } from '../icon/types';
-import type { ButtonProps } from '../button/types';
-import type { IconButtonProps } from '../icon-button/types';
-import type { LinkProps } from '../link/types';
export type NoticeIntent = 'warning' | 'success' | 'error' | 'info' | 'neutral';
@@ -41,61 +38,9 @@ export interface RootProps extends Omit< ComponentProps< 'div' >, 'title' > {
politeness?: 'polite' | 'assertive';
}
-export interface TitleProps extends ComponentProps< 'span' > {
- /**
- * The title text of the notice.
- */
- children?: ReactNode;
-}
-
export interface DescriptionProps extends ComponentProps< 'span' > {
/**
* The description text of the notice.
*/
children?: ReactNode;
}
-
-export interface ActionsProps extends ComponentProps< 'div' > {
- /**
- * The action buttons for the notice.
- */
- children?: ReactNode;
-}
-
-export interface CloseIconProps
- extends Omit<
- IconButtonProps,
- | 'loading'
- | 'loadingAnnouncement'
- | 'variant'
- | 'size'
- | 'tone'
- | 'label'
- | 'icon'
- > {
- /**
- * A label describing the button's action, shown as a tooltip and to
- * assistive technology.
- */
- label?: IconButtonProps[ 'label' ];
-
- /**
- * The icon to display in the button.
- */
- icon?: IconButtonProps[ 'icon' ];
-}
-
-export interface ActionButtonProps
- extends Omit< ButtonProps, 'size' | 'tone' > {
- /**
- * The content to be rendered inside the component.
- */
- children?: ReactNode;
-}
-
-export interface ActionLinkProps extends Omit< LinkProps, 'variant' | 'tone' > {
- /**
- * The content to be rendered inside the component.
- */
- children?: ReactNode;
-}
diff --git a/packages/ui/src/text/style.module.css b/packages/ui/src/text/style.module.css
index a2e1ea1d3f9..3357c26c2a1 100644
--- a/packages/ui/src/text/style.module.css
+++ b/packages/ui/src/text/style.module.css
@@ -6,88 +6,66 @@
}
.heading-2xl {
- --_gcd-heading-font-size: var(--wpds-typography-font-size-2xl);
-
- font-family: var(--wpds-typography-font-family-heading);
- font-size: var(--wpds-typography-font-size-2xl);
- line-height: var(--wpds-typography-line-height-2xl);
- font-weight: var(--wpds-typography-font-weight-medium);
+ font-family: var(--wpds-font-family-heading);
+ font-size: var(--wpds-font-size-2xl);
+ line-height: var(--wpds-font-line-height-2xl);
+ font-weight: var(--wpds-font-weight-medium);
}
.heading-xl {
- --_gcd-heading-font-size: var(--wpds-typography-font-size-xl);
-
- font-family: var(--wpds-typography-font-family-heading);
- font-size: var(--wpds-typography-font-size-xl);
- line-height: var(--wpds-typography-line-height-md);
- font-weight: var(--wpds-typography-font-weight-medium);
+ font-family: var(--wpds-font-family-heading);
+ font-size: var(--wpds-font-size-xl);
+ line-height: var(--wpds-font-line-height-md);
+ font-weight: var(--wpds-font-weight-medium);
}
.heading-lg {
- --_gcd-heading-font-size: var(--wpds-typography-font-size-lg);
-
- font-family: var(--wpds-typography-font-family-heading);
- font-size: var(--wpds-typography-font-size-lg);
- line-height: var(--wpds-typography-line-height-sm);
- font-weight: var(--wpds-typography-font-weight-medium);
+ font-family: var(--wpds-font-family-heading);
+ font-size: var(--wpds-font-size-lg);
+ line-height: var(--wpds-font-line-height-sm);
+ font-weight: var(--wpds-font-weight-medium);
}
.heading-md {
- --_gcd-heading-font-size: var(--wpds-typography-font-size-md);
-
- font-family: var(--wpds-typography-font-family-heading);
- font-size: var(--wpds-typography-font-size-md);
- line-height: var(--wpds-typography-line-height-sm);
- font-weight: var(--wpds-typography-font-weight-medium);
+ font-family: var(--wpds-font-family-heading);
+ font-size: var(--wpds-font-size-md);
+ line-height: var(--wpds-font-line-height-sm);
+ font-weight: var(--wpds-font-weight-medium);
}
.heading-sm {
- --_gcd-heading-font-size: var(--wpds-typography-font-size-xs);
-
- font-family: var(--wpds-typography-font-family-heading);
- font-size: var(--wpds-typography-font-size-xs);
- line-height: var(--wpds-typography-line-height-xs);
- font-weight: var(--wpds-typography-font-weight-medium);
+ font-family: var(--wpds-font-family-heading);
+ font-size: var(--wpds-font-size-xs);
+ line-height: var(--wpds-font-line-height-xs);
+ font-weight: var(--wpds-font-weight-medium);
text-transform: uppercase;
}
.body-xl {
- --_gcd-p-font-size: var(--wpds-typography-font-size-xl);
- --_gcd-p-line-height: var(--wpds-typography-line-height-xl);
-
- font-family: var(--wpds-typography-font-family-body);
- font-size: var(--wpds-typography-font-size-xl);
- line-height: var(--wpds-typography-line-height-xl);
- font-weight: var(--wpds-typography-font-weight-regular);
+ font-family: var(--wpds-font-family-body);
+ font-size: var(--wpds-font-size-xl);
+ line-height: var(--wpds-font-line-height-xl);
+ font-weight: var(--wpds-font-weight-regular);
}
.body-lg {
- --_gcd-p-font-size: var(--wpds-typography-font-size-lg);
- --_gcd-p-line-height: var(--wpds-typography-line-height-md);
-
- font-family: var(--wpds-typography-font-family-body);
- font-size: var(--wpds-typography-font-size-lg);
- line-height: var(--wpds-typography-line-height-md);
- font-weight: var(--wpds-typography-font-weight-regular);
+ font-family: var(--wpds-font-family-body);
+ font-size: var(--wpds-font-size-lg);
+ line-height: var(--wpds-font-line-height-md);
+ font-weight: var(--wpds-font-weight-regular);
}
.body-md {
- --_gcd-p-font-size: var(--wpds-typography-font-size-md);
- --_gcd-p-line-height: var(--wpds-typography-line-height-sm);
-
- font-family: var(--wpds-typography-font-family-body);
- font-size: var(--wpds-typography-font-size-md);
- line-height: var(--wpds-typography-line-height-sm);
- font-weight: var(--wpds-typography-font-weight-regular);
+ font-family: var(--wpds-font-family-body);
+ font-size: var(--wpds-font-size-md);
+ line-height: var(--wpds-font-line-height-sm);
+ font-weight: var(--wpds-font-weight-regular);
}
.body-sm {
- --_gcd-p-font-size: var(--wpds-typography-font-size-sm);
- --_gcd-p-line-height: var(--wpds-typography-line-height-xs);
-
- font-family: var(--wpds-typography-font-family-body);
- font-size: var(--wpds-typography-font-size-sm);
- line-height: var(--wpds-typography-line-height-xs);
- font-weight: var(--wpds-typography-font-weight-regular);
+ font-family: var(--wpds-font-family-body);
+ font-size: var(--wpds-font-size-sm);
+ line-height: var(--wpds-font-line-height-xs);
+ font-weight: var(--wpds-font-weight-regular);
}
}
diff --git a/packages/ui/src/text/text.tsx b/packages/ui/src/text/text.tsx
index c2c36e8691f..29ce1057676 100644
--- a/packages/ui/src/text/text.tsx
+++ b/packages/ui/src/text/text.tsx
@@ -3,7 +3,6 @@ import clsx from 'clsx';
import { forwardRef } from '@wordpress/element';
import { type TextProps } from './types';
import styles from './style.module.css';
-import defenseStyles from '../utils/css/global-css-defense.module.css';
/**
* A text component for rendering content with predefined typographic variants.
@@ -18,13 +17,7 @@ export const Text = forwardRef< HTMLSpanElement, TextProps >( function Text(
defaultTagName: 'span',
ref,
props: mergeProps< 'span' >( props, {
- className: clsx(
- styles.text,
- defenseStyles.heading,
- defenseStyles.p,
- styles[ variant ],
- className
- ),
+ className: clsx( styles.text, styles[ variant ], className ),
} ),
} );From my perspective, either approach is fine as long as it yields the same result.
There was a problem hiding this comment.
I think this approach could work, and yield the better future-compatibility with next releases?
|
Coming here to say that the designs shared for the Connectors flow use the new notice component as the connector items listed below use the card component and the style match will generate a better outcome. However, if the notice component is not ready and we need to go with the current one. That's also fine. |
The previous commit on this branch replaced `Notice` from `@wordpress/ui` with inline HTML/CSS in the connectors-home route because the component was not yet built on wp/7.0. Instead of carrying that workaround indefinitely, port the minimum subset of `Notice` (Root + Description) and its `Text` dependency from trunk so the route can use the real component. Scope is intentionally limited to what the connectors-home notice actually needs: - `Notice.Title`, `Notice.Actions`, `Notice.CloseIcon`, `Notice.ActionButton`, `Notice.ActionLink` are omitted, which avoids pulling in `Link` (not yet on wp/7.0) and the trunk-only `Button` / `IconButton` API additions (`tone`, `loading`, `variant="minimal"`, `size="compact"`). - `Text` drops the `global-css-defense.module.css` dependency since that module has not been backported to wp/7.0 and is unused for `<span>` rendering. - CSS design tokens are remapped from trunk's `--wpds-typography-*` back to wp/7.0's `--wpds-font-*` / `--wpds-font-line-height-*` naming. Replace the inline notice in `routes/connectors-home/stage.tsx` with `<Notice.Root intent="info"><Notice.Description>` and drop the manual `speak()` call (handled by `Notice.Root`'s `useSpokenMessage`). Remove the now-unused `__file-mods-notice-icon` / `__file-mods-notice-text` SCSS rules; keep only the wrapper `margin-bottom` for layout spacing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mirka
left a comment
There was a problem hiding this comment.
I tried using the
Noticecomponent with dbe1d35, but it was a bit tricky.
I see, thank you for the meticulous work here. I'm a little bit worried about omitting the defense styles from Text, because it could be a gotcha for other backports in the future. (The defense styles aren't necessary in this particular use case, but it could be in a future backport, and the problem may not be caught in review.)
But I wouldn't say it's a hard blocker.
|
Thanks Aki |
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Worked well on the tests I did 👍 Thank you for the fix!
|
Thank you all for your reviews! Let's merge this for now. I believe this will completely resolve the CI issues in the |
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62360 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. Built from https://develop.svn.wordpress.org/branches/7.0@62360 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: `git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy` Reviewed by desrosj. Merges [62360] to `trunk`. See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@62361 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `c15cef1d6b07f666df28dac0383bafb0edfe0914 ` to `3a4e8d1418d25da83b70158bcaabf65580690b6b`. The following changes are included: - [WP.7.0] Admin UI: Backport accessibility fixes (WordPress/gutenberg#77617, WordPress/gutenberg#78001) (WordPress/gutenberg#78002) - Fix: Shortcode block does not render in Navigation Overlay (WordPress/gutenberg#77511) - feat: Enhance Connectors page on read-only file system (WordPress/gutenberg#77521) - Connectors: Avoid using centered text (WordPress/gutenberg#78125) - Revisions: Add tooltip to diff marker buttons (WordPress/gutenberg#77690) - Add backport for WP_ALLOW_COLLABORATION (WordPress/gutenberg#78160) - Add aria-label to Revisions button in Post Summary sidebar (WordPress/gutenberg#78140) - Revisions diff markers: enforce 24×24px minimum target size (WCAG 2.5.8) (WordPress/gutenberg#77671) - Connectors: Replace @wordpress/ui Link and Notice usage (WordPress/gutenberg#78117) - Connectors: Increase right padding of callout for mobile layout (WordPress/gutenberg#78126) - isFulfilled: don't change resolution state, call in resolveSelect (WordPress/gutenberg#78201) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) (WordPress/gutenberg#78286) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/c15cef1d6b07f666df28dac0383bafb0edfe0914…3a4e8d1418d25da83b70158bcaabf65580690b6b. Log created with: `git log --reverse --format="- %s" c15cef1d6b07f666df28dac0383bafb0edfe0914..3a4e8d1418d25da83b70158bcaabf65580690b6b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy` Reviewed by desrosj. Merges [62360] to `trunk`. See #64595. Built from https://develop.svn.wordpress.org/trunk@62361 git-svn-id: http://core.svn.wordpress.org/trunk@61642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow-up to #77521
What?
Replace usage of
LinkandNoticefrom@wordpress/uiin theconnectors-homeroute with alternatives that work on thewp/7.0branch. This is a special fix for the 7.0 release.Why?
Build errors occur because
@wordpress/uihas not yet exposed theNoticeandLinkcomponents in thewp/7.0branch. As a result, in WP 7.0 RC3, although the Connectors page does not crash, there is an issue where related components are not rendered.How?
Uses
ExternalLinkfrom@wordpress/componentsinstead ofLinkfrom@wordpress/ui.Regarding
Notice, I implemented the same UI independently to replicate its appearance. The reason for not usingNoticefrom@wordpress/componentsis that the AI plugin is already usingNoticefrom@wordpress/ui. Since the Connectors page and the AI plugin settings page are closely related, I believe it is necessary to use a similar UI as an exception.Testing Instructions
DISALLOW_FILE_MODS:npx wp-env run cli wp config set DISALLOW_FILE_MODS true --rawwp-admin→ Connectors.npx wp-env run cli wp config delete DISALLOW_FILE_MODSScreenshots or screencast