Build: Fix is-shallow-equal default script export#78911
Closed
gigitux wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
[Package] is-shallow-equal
Member
|
Size Change: +59 B (0%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
@wordpress/is-shallow-equalscript global by enablingwpScriptDefaultExport.This makes
window.wp.isShallowEqualresolve directly to the package's default function instead of the full module namespace object.Alternative of #78699
Why?
After the esbuild migration, packages exposed through
window.wp.*can be consumed by external webpack builds as externals. For@wordpress/is-shallow-equal, default imports such as:could resolve to the namespace object instead of the default function, causing runtime errors like:
is-shallow-equalis primarily used as a callable default export, so it should opt intowpScriptDefaultExportlike other packages that expose their default export directly onwindow.wp.*.How?
"wpScriptDefaultExport": trueto@wordpress/is-shallow-equal.This preserves compatibility for consumers using the
window.wp.isShallowEqual.*helper properties while fixing default-import interop.Testing Instructions
Run:
Optionally build the package and confirm in the browser console:
Testing Instructions for Keyboard
Not applicable. This is a build/export compatibility fix with no UI changes.