Revert "wp-build: Replace getter-based exports with data properties"#78917
Merged
gigitux merged 2 commits intoJun 3, 2026
Merged
Conversation
gigitux
added
the
Backport to Gutenberg Minor Release
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -2.37 kB (-0.03%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
Member
Judging by the issue description, I'm understanding the issue not to be that this is |
aduth
approved these changes
Jun 3, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Tested locally as described above, and verified that the changes are a clean revert of the original code (not including the changelog).
Contributor
Author
Good point! I updated the PR description! Thanks! |
gigitux
deleted the
revert-78303-perf/replace-getter-exports-with-data-properties
branch
2 tasks
arthur791004
removed
the
Backport to Gutenberg Minor Release
1 task
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #78303.
This PR reverts the patch introduced in #78303, which replaced getter-based exports in
@wordpress/buildwith data properties.Why?
Gutenberg 23.0 introduced regressions tracked in #78697. For additional context, see:
Reverting the change restores the previous behavior while we prepare a patch release. After the patch release is shipped, we can revisit the approach from #78303 and explore an alternative solution.
How?
This reverts the changes from #78303 in
packages/wp-build/lib/build.mjs, restoring the previous getter-based export behavior.Testing Instructions
npm run build.window.wp.isShallowEqual.__esModuleisn't undefined.Testing Instructions for Keyboard
This PR does not change the user interface.
Screenshots or screencast
Not applicable.