Ensure plugin passes all Plugin Check categories#2
Open
ironprogrammer wants to merge 6 commits into
Open
Conversation
Addresses errors for WordPress.Security.EscapeOutput.OutputNotEscaped.
Address PCP error for WordPress.WP.AlternativeFunctions.rand_mt_rand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per recent plugin directory submission requirements, plugins that trigger any error level for Plugin Check (PCP) "Plugin Repo" category checks are barred from submission. Let's make sure Hello Dolly would pass the tests with PCP 1.2.0!
mt_rand()in https://core.trac.wordpress.org/ticket/61215.stable_tag_mismatcherror occurs when testing the plugin from the directory).Note: One check not resolved with this update is a warning for
plugin_header_invalid_plugin_uri_domain. This occurs when the Plugin URI containswordpress.org, but would not block submission on its own.Props narenin, sergeybiryukov, ironprogrammer.