Update Playground dependencies to 0.6.7#157
Merged
adamziel merged 6 commits intoMar 6, 2024
Merged
Conversation
Collaborator
Author
|
The fix introduced on WordPress/wordpress-playground#1000, seems to be failing. The "transpiled" JS is like: Where So it's not really importing the cyrpto library from Node.js |
…date/playground-dependencies-to-introduce-crypto-globally
Collaborator
Author
|
I confirm after upgrading the dependencies, Now I can run blueprints: |
Collaborator
Author
|
@adamziel , this PR is ready for review. I can release wp-now after this one is merged. |
sejas
commented
Feb 20, 2024
Comment on lines
+1
to
+5
| <?php | ||
|
|
||
| // File needs to exist to avoid throwing a 404 error | ||
|
|
||
| header('Location: /wp-admin/'); |
Collaborator
Author
There was a problem hiding this comment.
This new wp-login.php file is necessary to avoid this new exception on the blueprint step:
Collaborator
|
@sejas 0.6.5 is out. We should update this branch to the latest version. |
Collaborator
Author
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
* Fix the tests setup * Add test types * Tolerate import.meta.env in php.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
To remove crypto dependency in node applications
How?
Updating the main
package.jsonTesting Instructions
nvm use && npm installnpm run buildnode dist/packages/wp-now/cli.js start --blueprint=b.jsonwhere b.json is a blueprint withTypeError: crypto.randomUUID is not a function