Skip to content

Use configured PHP binary in CLI parsing tests#295

Open
adamziel wants to merge 1 commit into
trunkfrom
split/use-php-binary-in-cli-test
Open

Use configured PHP binary in CLI parsing tests#295
adamziel wants to merge 1 commit into
trunkfrom
split/use-php-binary-in-cli-test

Conversation

@adamziel

@adamziel adamziel commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What it does

Makes OnlyCliParseTest invoke the importer with PHP_BINARY instead of a hard-coded php.

Rationale

The test should exercise the same PHP executable as PHPUnit. This avoids surprises on systems where php on PATH differs from the runtime running the test suite.

Implementation

The CLI helper now builds commands from PHP_BINARY and suppresses startup-warning output with -d display_startup_errors=0.

Testing instructions

  • cd tests && ../vendor/bin/phpunit --colors=never Import/OnlyCliParseTest.php

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.7

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 9.81 s 9.55 s ⚪ +252 ms (+2.6%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.57 s 3.57 s ⚪ -3 ms (-0.1%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 13.38 s 13.13 s ⚪ +249 ms (+1.9%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

@adamziel adamziel closed this Jul 2, 2026
@adamziel adamziel reopened this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant