[Push] Serve every push request without loading WordPress#378
Open
adamziel wants to merge 1 commit into
Open
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
9.88 s | 9.52 s | ⚪ +359 ms (+3.8%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.60 s | 3.58 s | ⚪ +25 ms (+0.7%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 13.48 s | 13.10 s | ⚪ +384 ms (+2.9%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
adamziel/push-no-boot-recovery
branch
from
July 20, 2026 19:05
e7cc342 to
9ce62b0
Compare
adamziel
changed the base branch from
adamziel/push-journal-clear-planning
to
trunk
July 20, 2026 19:05
adamziel
force-pushed
the
adamziel/push-no-boot-recovery
branch
2 times, most recently
from
July 20, 2026 21:17
c08131b to
5767c1b
Compare
adamziel
force-pushed
the
adamziel/push-no-boot-recovery
branch
3 times, most recently
from
July 20, 2026 23:52
16ea739 to
40c8d42
Compare
adamziel
force-pushed
the
adamziel/push-no-boot-recovery
branch
from
July 21, 2026 01:20
40c8d42 to
cb8dff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
files-pushrequests now use a PHP route that does not boot WordPress, so a new push can replace files which broke WordPress startup.Background
A push can install a plugin which throws while WordPress starts. If
push_creategoes through WordPress, the next push cannot start and replace that plugin.This change
Create, upload, status, commit, and remove now use one push URL. The WordPress route serves pull requests only and rejects every
push_*request.push_createuses the connection token. It returns a random secret for that push session. The other four operations use the session secret at the same URL.There is still one implementation of each push operation.
Site_Export_HTTP_Server::serve_push()authenticates the request and dispatches it to the existingSite_Export_Push_Endpointsmethods. The old WordPress-side push setup and dispatch are removed.The bundled URL ends in:
The Reprint Exporter settings screen shows the exact URL. Pass it to
files-pushinstead of?reprint-api:The bundled route reads
DOCUMENT_ROOT, uses its private sibling reprint directory, and excludes its own plugin directory from push.Enabling push writes the connection token to the mode-0600
<reprint-directory>/.reprint/push-config.php. The file returns a PHP array and prints nothing. Each push session keeps its secret and policy in a mode-0600push-metadata.php, which also returns an array without printing it. Removingpush-config.phpblocks new sessions without breaking a session already in progress.Some hosts block direct PHP below
wp-content/plugins, or use different server-owned paths. Those hosts must expose another PHP URL which does not load WordPress:Give that URL directly to
files-push. The WordPresssite_export_api_optionsfilter no longer configures push.Testing
Push a plugin which makes the WordPress route return HTTP 500. Replace the local plugin with a safe version and run
files-pushagain with the same state directory. Confirm that the second run creates a new push session and repairs the site throughpush.php.