update deploy.yml

[masteradhoc]

Fixes #655

What?

Updates the GitHub Actions deploy workflow to replace the archived actions/upload-release-asset action with the maintained softprops/action-gh-release action for uploading release assets.

Why?

The actions/upload-release-asset action is archived and no longer maintained. Its own documentation recommends migrating to softprops/action-gh-release. Continuing to rely on an archived action poses maintenance and reliability risks for future releases.

How?

Replaced actions/upload-release-asset@v1 with softprops/action-gh-release@v2.

• Added a small preparation step to rename the generated ZIP file so the uploaded release asset keeps the existing, expected name (.zip).
• Removed deprecated inputs (upload_url, asset_path, asset_name, asset_content_type) that are specific to the old action and not used by action-gh-release.

Testing Instructions

1. Create and push a tag (e.g. git tag vX.Y.Z && git push origin vX.Y.Z).
2. Verify the GitHub Actions workflow completes successfully.
3. Confirm a GitHub Release exists for the tag.
4. Confirm the release contains an asset named .zip with the expected contents.

Screenshots or screencast

Changelog Entry

Changed – Replace deprecated GitHub Actions release asset upload step with a maintained alternative.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: masteradhoc <masteradhoc@git.wordpress.org>
Co-authored-by: kasparsd <kasparsd@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[kasparsd]

I believe the ${{ steps.deploy.outputs.zip-path }} is already the ZIP file with the proper extension per:

https://github.com/10up/action-wordpress-plugin-deploy/blob/008657da18d18e065aaaccd287fa3af53ff768a1/deploy.sh#L115

The previous action used asset_name: ${{ github.event.repository.name }}.zip to rename for the releases list in the UI.

[masteradhoc]

Thanks @kasparsd just removed the prepare release asset part and used the variable directly.
i hope this works as i couldnt test it without access to the repo.

would you be open to prepare a test release (beta maybe) to test this together?