Skip to content

Block Supports: Add height to dimensions supports #10474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronrobertshaw wants to merge 3 commits into from
Closed

Block Supports: Add height to dimensions supports #10474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db677b
Block Supports: Add height to dimensions supports
aaronrobertshaw Nov 6, 2025
98c79fb
Add missing dimensions tests
aaronrobertshaw Feb 12, 2026
7f0f17f
Updated ticket number for test
ramonjd Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/block-supports/dimensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function wp_apply_dimensions_support( $block_type, $block_attributes ) {
}

$dimensions_block_styles = array();
$supported_features = array( 'minHeight', 'width' );
$supported_features = array( 'minHeight', 'height', 'width' );

foreach ( $supported_features as $feature ) {
$has_support = block_has_support( $block_type, array( 'dimensions', $feature ), false );
Expand Down
12 changes: 8 additions & 4 deletions src/wp-includes/class-wp-theme-json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class WP_Theme_JSON {
* @since 6.5.0 Added `aspect-ratio` property.
* @since 6.6.0 Added `background-[image|position|repeat|size]` properties.
* @since 6.7.0 Added `background-attachment` property.
* @since 7.0.0 Added `dimensions.width`.
* @since 7.0.0 Added `dimensions.width` and `dimensions.height`.
* @var array
*/
const PROPERTIES_METADATA = array(
Expand Down Expand Up @@ -302,6 +302,7 @@ class WP_Theme_JSON {
'text-transform' => array( 'typography', 'textTransform' ),
'filter' => array( 'filter', 'duotone' ),
'box-shadow' => array( 'shadow' ),
'height' => array( 'dimensions', 'height' ),
'width' => array( 'dimensions', 'width' ),
'writing-mode' => array( 'typography', 'writingMode' ),
);
Expand Down Expand Up @@ -398,7 +399,7 @@ class WP_Theme_JSON {
* 'typography.defaultFontSizes', and 'spacing.defaultSpacingSizes'.
* @since 6.9.0 Added support for `border.radiusSizes`.
* @since 7.0.0 Added type markers to the schema for boolean values.
* Added support for `dimensions.width`.
* Added support for `dimensions.width` and `dimensions.height`.
* @var array
*/
const VALID_SETTINGS = array(
Expand Down Expand Up @@ -437,6 +438,7 @@ class WP_Theme_JSON {
'aspectRatio' => null,
'aspectRatios' => null,
'defaultAspectRatios' => null,
'height' => null,
'minHeight' => null,
'width' => null,
),
Expand Down Expand Up @@ -532,7 +534,7 @@ class WP_Theme_JSON {
* @since 6.3.0 Added support for `typography.textColumns`.
* @since 6.5.0 Added support for `dimensions.aspectRatio`.
* @since 6.6.0 Added `background` sub properties to top-level only.
* @since 7.0.0 Added support for `dimensions.width`.
* @since 7.0.0 Added support for `dimensions.width` and `dimensions.height`.
* @var array
*/
const VALID_STYLES = array(
Expand Down Expand Up @@ -560,6 +562,7 @@ class WP_Theme_JSON {
),
'dimensions' => array(
'aspectRatio' => null,
'height' => null,
'minHeight' => null,
'width' => null,
),
Expand Down Expand Up @@ -772,7 +775,7 @@ public static function get_element_class_name( $element ) {
* @since 6.2.0 Added `dimensions.minHeight` and `position.sticky`.
* @since 6.4.0 Added `background.backgroundImage`.
* @since 6.5.0 Added `background.backgroundSize` and `dimensions.aspectRatio`.
* @since 7.0.0 Added `dimensions.width`.
* @since 7.0.0 Added `dimensions.width` and `dimensions.height`.
* @var array
*/
const APPEARANCE_TOOLS_OPT_INS = array(
Expand All @@ -787,6 +790,7 @@ public static function get_element_class_name( $element ) {
array( 'color', 'button' ),
array( 'color', 'caption' ),
array( 'dimensions', 'aspectRatio' ),
array( 'dimensions', 'height' ),
array( 'dimensions', 'minHeight' ),
array( 'dimensions', 'width' ),
array( 'position', 'sticky' ),
Expand Down
6 changes: 6 additions & 0 deletions src/wp-includes/style-engine/class-wp-style-engine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ final class WP_Style_Engine {
'has-aspect-ratio' => true,
),
),
'height' => array(
'property_keys' => array(
'default' => 'height',
),
'path' => array( 'dimensions', 'height' ),
),
'minHeight' => array(
'property_keys' => array(
'default' => 'min-height',
Expand Down
71 changes: 71 additions & 0 deletions tests/phpunit/tests/block-supports/wpApplyDimensionsSupport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,4 +171,75 @@ public function data_width_block_support() {
),
);
}

/**
* Tests that height block support works as expected.
*
* @ticket 64202
*
* @covers ::wp_apply_dimensions_support
*
* @dataProvider data_height_block_support
*
* @param string $block_name The test block name to register.
* @param mixed $dimensions The dimensions block support settings.
* @param mixed $expected The expected results.
*/
public function test_height_block_support( $block_name, $dimensions, $expected ) {
$this->test_block_name = $block_name;
register_block_type(
$this->test_block_name,
array(
'api_version' => 2,
'attributes' => array(
'style' => array(
'type' => 'object',
),
),
'supports' => array(
'dimensions' => $dimensions,
),
)
);
$registry = WP_Block_Type_Registry::get_instance();
$block_type = $registry->get_registered( $this->test_block_name );
$block_attrs = array(
'style' => array(
'dimensions' => array(
'height' => '400px',
),
),
);

$actual = wp_apply_dimensions_support( $block_type, $block_attrs );

$this->assertSame( $expected, $actual );
}

/**
* Data provider.
*
* @return array
*/
public function data_height_block_support() {
return array(
'style is applied' => array(
'block_name' => 'test/height-style-is-applied',
'dimensions' => array(
'height' => true,
),
'expected' => array(
'style' => 'height:400px;',
),
),
'style output is skipped when individual feature serialization is skipped' => array(
'block_name' => 'test/height-with-individual-skipped-serialization-block-supports',
'dimensions' => array(
'height' => true,
'__experimentalSkipSerialization' => array( 'height' ),
),
'expected' => array(),
),
);
}
}
2 changes: 2 additions & 0 deletions tests/phpunit/tests/theme/wpThemeJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ public function test_get_settings_appearance_true_opts_in() {
),
'dimensions' => array(
'aspectRatio' => true,
'height' => true,
'minHeight' => true,
'width' => true,
),
Expand Down Expand Up @@ -320,6 +321,7 @@ public function test_get_settings_appearance_true_opts_in() {
),
'dimensions' => array(
'aspectRatio' => true,
'height' => true,
'minHeight' => true,
'width' => true,
),
Expand Down
Loading