Add styles for responsive grid layout#10766
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
4402f2c to
7935404
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| <div class="wp-block-columns has-3-columns is-layout-flex wp-container-1d6595d7 wp-block-columns-is-layout-flex"> | |||
| <div class="wp-block-columns has-3-columns is-layout-flex wp-container-1f761849 wp-block-columns-is-layout-flex"> | |||
There was a problem hiding this comment.
Columns block hashes changed due to updates this PR makes to flex layout gap calculation,
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for the work on this @tellthemachines 👍
✅ This is testing as advertised
✅ Code appears consistent with the layout support and tests in Gutenberg
LGTM 🚢
Trac ticket: https://core.trac.wordpress.org/ticket/64532
Adds responsive grid styles related to WordPress/gutenberg#73662 (the PHP changes were already in Gutenberg since WordPress/gutenberg#62777 as part of an experiment)
and blockGap bug fix from WordPress/gutenberg#74725
Steps for testing
Add this markup to a post:
Save and publish. Check that the grid has 3 columns on the front end.
Go back to the editor and change min column width to be 800px. Save and go back to the front end. Switch view to mobile and check there's no horizontal scroll.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.