Skip to content

Add styles for responsive grid layout#10766

Closed
tellthemachines wants to merge 6 commits into
WordPress:trunkfrom
tellthemachines:add/responsive-grid-styles
Closed

Add styles for responsive grid layout#10766
tellthemachines wants to merge 6 commits into
WordPress:trunkfrom
tellthemachines:add/responsive-grid-styles

Conversation

@tellthemachines
Copy link
Copy Markdown
Contributor

@tellthemachines tellthemachines commented Jan 20, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64532

Adds responsive grid styles related to WordPress/gutenberg#73662 (the PHP changes were already in Gutenberg since WordPress/gutenberg#62777 as part of an experiment)
and blockGap bug fix from WordPress/gutenberg#74725

Steps for testing

Add this markup to a post:

<!-- wp:group {"align":"wide","layout":{"type":"grid","columnCount":3,"minimumColumnWidth":"117px"}} -->
<div class="wp-block-group alignwide"><!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">content</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">content</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">content</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">contente</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">content</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">contentnn</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"backgroundColor":"accent-1"} -->
<p class="has-accent-1-background-color has-background">contnt</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

Save and publish. Check that the grid has 3 columns on the front end.

Go back to the editor and change min column width to be 800px. Save and go back to the front end. Switch view to mobile and check there's no horizontal scroll.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@tellthemachines tellthemachines force-pushed the add/responsive-grid-styles branch from 4402f2c to 7935404 Compare January 22, 2026 03:50
@tellthemachines tellthemachines marked this pull request as ready for review January 22, 2026 04:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 22, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, aaronrobertshaw.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -1,5 +1,5 @@

<div class="wp-block-columns has-3-columns is-layout-flex wp-container-1d6595d7 wp-block-columns-is-layout-flex">
<div class="wp-block-columns has-3-columns is-layout-flex wp-container-1f761849 wp-block-columns-is-layout-flex">
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Columns block hashes changed due to updates this PR makes to flex layout gap calculation,

Copy link
Copy Markdown

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @tellthemachines 👍

✅ This is testing as advertised
✅ Code appears consistent with the layout support and tests in Gutenberg

LGTM 🚢

Screenshot 2026-01-22 at 3 05 28 pm

@tellthemachines tellthemachines added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 23, 2026
@github-actions github-actions Bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 23, 2026
@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61513
GitHub commit: ea33087

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants