Site Health: Add missing dashicons class to error span fixes #65014#11440
Open
Webizito wants to merge 27 commits into
Open
Site Health: Add missing dashicons class to error span fixes #65014#11440Webizito wants to merge 27 commits into
Webizito wants to merge 27 commits into
Conversation
|
Hi @Webizito! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
t-hamano
approved these changes
Apr 4, 2026
sabernhardt
reviewed
Apr 4, 2026
Site Health: Move dashicons class before error class for consistency Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Author
|
Thanks @sabernhardt! Updated the class order to put dashicons first for consistency as suggested. |
sabernhardt
reviewed
Apr 9, 2026
Contributor
|
@Webizito, As mentioned in this comment, it is not necessary to regularly merge trnk into this PR. |
The ASCII fast-path in `_wp_scan_utf8()` uses `strspn()` to skip past ASCII bytes. When a code point limit was provided without a byte limit, the scan would include the rest of the input even when there was a code point limit. Because ASCII characters are single-byte code points, the fast-path scan length can be bounded by the number of remaining code points. This improves performance when working with some large documents. Developed in WordPress#12214. Follow-up to [60768]. Props jonsurrell, dmsnell, zieladam. Fixes #65483. See #63863. git-svn-id: https://develop.svn.wordpress.org/trunk@62523 602fd350-edb4-49c9-b593-d223f7449a82
When a trace of allocations revealed that `wp_is_numeric_array()` accounted for a significant fraction of the allocations in a page render, it was observed that the function eagerly allocates and copies array keys and then filters them when all it wants to know is whether a single key in the array meets a condition. In this patch the `array_filter( array_keys() )` invocation is replaced with early-aborting iteration to avoid the memory allocation and copying. This patch was prepared as part of WCEU 2026 Contributor Day. Developed in: WordPress#12100 Discussed in: https://core.trac.wordpress.org/ticket/65467 Follow-up to [34927]. Props dmsnell, westonruter, yusufmudagal. Fixes #65467. git-svn-id: https://develop.svn.wordpress.org/trunk@62524 602fd350-edb4-49c9-b593-d223f7449a82
Block editor-related files can currently become stale or are not always deleted from `src` through the relevant `grunt clean` commands reliably. In the past, this primarily caused issues locally when a CSS file was copied from the `@wordpress/block-library` npm package into `src` and later removed from the package entirely. The result was a failing `grunt verify:old-files` task until the `grunt clean` command was run with the `--dev` flag. After [61438] this issue presented in new ways. Mainly, files would remain in the core.svn.wordpress.org build repository indefinitely unless explicitly deleted. [62051] brought the `grunt clean` tasks up to date, but there are still paths where files remain unexpectedly or have outdated contents after rebuilding. This can cause incomplete or inaccurate commits where built files subject to version control are not updated correctly, especially when changing the `gutenberg.sha` value in `package.json`. This change improves the build script to ensure that all files sourced from the zip file with assets built by the Gutenberg repository are always fresh and up to date, and any files that are deleted from the built zip file are also deleted from version control appropriately (in both the `develop` and `core` repositories). A handful of changes were required to accomplish this: - All Gutenberg-sourced outputs are written to `src/` regardless of `--dev`. In production builds, `build:gutenberg` runs before `build:files`, and `copy:files` propagates the tree to `build/`. - `gutenbergFiles` has been split into two different arrays: `gutenbergUnversionedFiles` and `gutenbergVersionedFiles`. The `src` argument for the `clean:gutenberg` task is dynamically populated at run time with a bare `grunt clean` cleaning only the unversioned subset (so version-controlled files are not unexpectedly deleted), and explicit `clean:gutenberg` (or any chain through `build:gutenberg`) cleans both, removing files deleted upstream from version control. - `clean:gutenberg` no longer wipes non-Gutenberg sourced files from `wp-includes/js/`. All file/path lists have been updated to only match files the related tasks are directly responsible for managing. - `tools/gutenberg/copy.js` has been added to `tsconfig.json` and brought under `tsc --build` strict-mode checking. The large `copyBlockAssets()` function was broken into one named function per asset type, each typed against the relevant `COPY_CONFIG` slice. The split is a code-clarity improvement, not a bug fix. Props desrosj, westonruter, jorbin, adamsilverstein. Fixes #65452. git-svn-id: https://develop.svn.wordpress.org/trunk@62525 602fd350-edb4-49c9-b593-d223f7449a82
Instead of crowding the row, actions added by extenders should wrap to new lines. This change has been tested in both the classic editor plugin and hotfix plugin. Follow-up to [61645]. Props abhishekfdd, masteradhoc, rlucian, sabernhardt, cogdesign, threadi, darshitrajyaguru97, desrosj, davidbaumwald, jorbin. Fixes #65286. git-svn-id: https://develop.svn.wordpress.org/trunk@62526 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [47740]. Props nareshbheda, manishxdp. Fixes #65470. git-svn-id: https://develop.svn.wordpress.org/trunk@62527 602fd350-edb4-49c9-b593-d223f7449a82
This eliminates over 400 PHPStan errors from the core codebase. * Clarify the inline documentation for the four `wpdb` query methods — `get_results()`, `get_row()`, `get_col()`, and `get_var()`. * Add `@phpstan-return` conditional types that mirror each method's runtime dispatch on `$query` and `$output`. * Add `@phpstan-param` tags narrowing `$output` to the documented constants. * Document that `get_var()` returns `null` both on failure and when the matched cell value is an empty string, directing consumers to `$this->last_error` to distinguish the two cases. * Tighten the `@return` in `get_results()` from `array|object|null` to `array|null`, since the method never returns a bare `stdClass`; the `object` was a copy/paste artifact from `get_row()`. * Fix a deprecated use of `null` as an array offset (PHP 8.5) in the `OBJECT_K` branch when a row's first column is SQL `NULL`. * Gather `get_col()` data as a true list. * Suggest `ext-mysqli` in `composer.json`, which `wpdb` requires at runtime. Developed in WordPress#11855. Props apermo, westonruter. See #30257, #64898. Fixes #65261. git-svn-id: https://develop.svn.wordpress.org/trunk@62529 602fd350-edb4-49c9-b593-d223f7449a82
Add SVG presentation attributes to the list of CSS properties allowed by `safecss_filter_attr()`, so inline SVG markup can be styled via the `style` attribute. This ports Gutenberg PR #79172 to Core. Props afercia, westonruter, wildworks. Fixes #65457. git-svn-id: https://develop.svn.wordpress.org/trunk@62530 602fd350-edb4-49c9-b593-d223f7449a82
…r buttons. Developed in: WordPress#11483 Props pratiknawkar94, joedolson, westonruter, afercia. Fixes #64576. git-svn-id: https://develop.svn.wordpress.org/trunk@62531 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [59039], [59291]. Props harishtewari, salmanshafiq8630, amitjoel85, SergeyBiryukov. Fixes #65492. git-svn-id: https://develop.svn.wordpress.org/trunk@62532 602fd350-edb4-49c9-b593-d223f7449a82
…ction. Every GitHub Actions workflow performing operations that may modify versioned files ends with a `git diff` check for uncommitted changes. The workflow run fails when changes exist to ensure requried changes are not missed in a given commit. Because the `git diff` only detects unstaged changes to tracked files, newly created files that were not also added to version control can easily go undetected. `git diff` also does not include changes to binary files by default. This commit makes the following changes to improve the related steps in workflow files: - The command used for detecting is changed to `git status --porcelain`, which only reports as clean when there are no changes to tracked files (both staged or unstaged) and there are no untracked files. - The related workflows have been updated to include `git add -A` before creating any patches to ensure that all new, modified, and deleted files are represented in the diff files created. - The `--binary` flag has been added to all `git diff` commands creating patches to ensure those changes are also included. Props desrosj. See #64893. git-svn-id: https://develop.svn.wordpress.org/trunk@62533 602fd350-edb4-49c9-b593-d223f7449a82
Because old branches reference the reusable workflow files in `trunk` and their respective `.gitignore` files were not updated, some adjustments are needed to prevent failures in numbered branches. Follow up to [62533]. See #64893. git-svn-id: https://develop.svn.wordpress.org/trunk@62534 602fd350-edb4-49c9-b593-d223f7449a82
This adds the `reusable-phpunit-tests-v3.yml` file to the list of changes that will run the `test-old-branches.yml` workflow. There are several numbered branches that reference this reusable workflow, so any changes should be verified across all calling branches. See #64893. git-svn-id: https://develop.svn.wordpress.org/trunk@62535 602fd350-edb4-49c9-b593-d223f7449a82
More work is needed to ensure these changes do not introduce failures in old branches. Reverts [62533], [62534]. See #64893. git-svn-id: https://develop.svn.wordpress.org/trunk@62536 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [59317]. Props khokansardar, nimeshatxecurify, sabernhardt, SergeyBiryukov. Fixes #65468. git-svn-id: https://develop.svn.wordpress.org/trunk@62537 602fd350-edb4-49c9-b593-d223f7449a82
Add aria-hidden attribute to Site Health error dashicon per review feedback. Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Error icon not showing in Tools → Site Health → Status
because dashicons class is missing from error span.
Fix
Added missing dashicons class to the error span element.
Missed during cleanup in #45309.
Testing
add_filter( 'pre_http_request', function( $response, $parsed_args, $url ) { if ( false !== strpos( $url, 'api.wordpress.org' ) ) { return new WP_Error( 'http_request_failed', 'Intentional failure.' ); } return $response; }, 10, 3 );Then go to Tools → Site Health → Status and verify icon is visible.
Trac ticket: (https://core.trac.wordpress.org/ticket/65014)
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.