Query: Preserve query strings in old slug redirects.#11916
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Why?
wp_old_slug_redirect()redirects requests for previous post slugs to the current permalink, but it currently drops the original query string.This can remove tracking or campaign parameters. For example,
/old-slug/?utm_source=flyerredirects to/new-slug/instead of/new-slug/?utm_source=flyer.How?
This preserves the original
$_SERVER['QUERY_STRING']when building the old-slug redirect URL.The query string is appended as-is, without parsing or rebuilding it, so encoded values and duplicate query args remain unchanged.
Testing
Automated test:
Manual test:
old-slug.new-slug./old-slug/?utm_source=flyer&campaign=spring./new-slug/?utm_source=flyer&campaign=springTrac ticket: #65267