Skip to content

Query: Preserve query strings in old slug redirects.#11916

Open
deepakpra wants to merge 4 commits into
WordPress:trunkfrom
deepakpra:fix/65267-old-slug-query-string
Open

Query: Preserve query strings in old slug redirects.#11916
deepakpra wants to merge 4 commits into
WordPress:trunkfrom
deepakpra:fix/65267-old-slug-query-string

Conversation

@deepakpra
Copy link
Copy Markdown

@deepakpra deepakpra commented May 21, 2026

Why?

wp_old_slug_redirect() redirects requests for previous post slugs to the current permalink, but it currently drops the original query string.

This can remove tracking or campaign parameters. For example, /old-slug/?utm_source=flyer redirects to /new-slug/ instead of /new-slug/?utm_source=flyer.

How?

This preserves the original $_SERVER['QUERY_STRING'] when building the old-slug redirect URL.

The query string is appended as-is, without parsing or rebuilding it, so encoded values and duplicate query args remain unchanged.

Testing

Automated test:

npm run test:php -- --filter Tests_Rewrite_OldSlugRedirect

Manual test:

  1. Create or edit a published post with the slug old-slug.
  2. Change the post slug to new-slug.
  3. Visit /old-slug/?utm_source=flyer&campaign=spring.
  4. Confirm it redirects to /new-slug/?utm_source=flyer&campaign=spring

Trac ticket: #65267

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props deepakprajapati, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@deepakpra deepakpra marked this pull request as draft May 21, 2026 08:31
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@deepakpra deepakpra marked this pull request as ready for review May 25, 2026 05:32
Comment thread src/wp-includes/query.php Outdated
@deepakpra deepakpra requested a review from westonruter May 28, 2026 06:05
Comment thread tests/phpunit/tests/rewrite/oldSlugRedirect.php Outdated
Comment thread tests/phpunit/tests/rewrite/oldSlugRedirect.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants