Skip to content

Media: Correct attachment count in featured image modal. #11951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SwapnilWordpress wants to merge 2 commits into
base: trunk
Choose a base branch
from
+12 −6
Open

Media: Correct attachment count in featured image modal. #11951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee70508
Media: Correct attachment count in featured image modal.
SwapnilWordpress May 22, 2026
0952884
Merge branch 'trunk' into fix/58729-media-library-count
SwapnilWordpress May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/js/media/models/attachments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,26 +239,32 @@ var Attachments = Backbone.Collection.extend(/** @lends wp.media.model.Attachmen
return this;
},
/**
* Update total attachment count when items are added to a collection.
* Update total attachment count when items are removed from the mirrored collection.
*
* @access private
*
* @since 5.8.0
*
* @param {wp.media.model.Attachment} attachment The attachment model.
* @param {wp.media.model.Attachments} collection The collection that triggered the event.
*/
_removeFromTotalAttachments: function() {
if ( this.mirroring ) {
_removeFromTotalAttachments: function( attachment, collection ) {
if ( this.mirroring && collection === this.mirroring ) {
this.mirroring.totalAttachments = this.mirroring.totalAttachments - 1;
}
},
/**
* Update total attachment count when items are added to a collection.
* Update total attachment count when items are added to the mirrored collection.
*
* @access private
*
* @since 5.8.0
*
* @param {wp.media.model.Attachment} attachment The attachment model.
* @param {wp.media.model.Attachments} collection The collection that triggered the event.
*/
_addToTotalAttachments: function() {
if ( this.mirroring ) {
_addToTotalAttachments: function( attachment, collection ) {
if ( this.mirroring && collection === this.mirroring ) {
this.mirroring.totalAttachments = this.mirroring.totalAttachments + 1;
}
},
Expand Down
Loading