Skip to content

#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide#12008

Open
masteradhoc wants to merge 1 commit into
WordPress:trunkfrom
masteradhoc:58969-copied
Open

#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide#12008
masteradhoc wants to merge 1 commit into
WordPress:trunkfrom
masteradhoc:58969-copied

Conversation

@masteradhoc
Copy link
Copy Markdown

When a user double-clicks the "Copy suggested policy text to clipboard" button, the "Copied!" notice text was included in the clipboard contents when pasted.

The root cause: document.execCommand('copy') copies all text content within the selected range, including text that is merely visually hidden via CSS. The .success ("Copied!") span and the button label both live inside .privacy-settings-accordion-actions, which sits inside the panel being selected — so their text was always part of the copy, becoming noticeable on double-click when the notice is visibly rendered.

The fix adds .privacy-settings-accordion-actions to the existing hide-privacy-policy-tutorial class before selectNodeContents runs, then removes it immediately after — the same mechanism already used to exclude tutorial paragraphs from the copied content.

Trac ticket: https://core.trac.wordpress.org/ticket/58969

Use of AI Tools

AI assistance: Yes
Tool(s): Claude (claude.ai)
Model(s): Claude Sonnet 4.6
Used for: Debugging and identifying the root cause; the fix was reviewed, tested, and approved by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props masteradhoc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant