#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide#12008
#58969: Fix double-click copying "Copied!" notice text to clipboard in Privacy Policy Guide#12008masteradhoc wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When a user double-clicks the "Copy suggested policy text to clipboard" button, the "Copied!" notice text was included in the clipboard contents when pasted.
The root cause:
document.execCommand('copy')copies all text content within the selected range, including text that is merely visually hidden via CSS. The.success("Copied!") span and the button label both live inside.privacy-settings-accordion-actions, which sits inside the panel being selected — so their text was always part of the copy, becoming noticeable on double-click when the notice is visibly rendered.The fix adds
.privacy-settings-accordion-actionsto the existinghide-privacy-policy-tutorialclass beforeselectNodeContentsruns, then removes it immediately after — the same mechanism already used to exclude tutorial paragraphs from the copied content.Trac ticket: https://core.trac.wordpress.org/ticket/58969
Use of AI Tools
AI assistance: Yes
Tool(s): Claude (claude.ai)
Model(s): Claude Sonnet 4.6
Used for: Debugging and identifying the root cause; the fix was reviewed, tested, and approved by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.