Skip to content

Tests: Convert repetitive s-type methods to use @dataProvider in parseQuery.php #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronjorbin wants to merge 2 commits into
base: trunk
Choose a base branch
from
+23 −45
Open

Tests: Convert repetitive s-type methods to use @dataProvider in parseQuery.php #12073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be1de3
Tests: Convert repetitive s-type methods to use @dataProvider in pars…
aaronjorbin May 30, 2026
9d96eaa
Merge branch 'trunk' into add/dataProvider-parse-query-s-types
aaronjorbin Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 23 additions & 45 deletions tests/phpunit/tests/query/parseQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,61 +5,39 @@
*/
class Tests_Query_ParseQuery extends WP_UnitTestCase {
/**
* @ticket 29736
* Data provider for test_parse_query_s_type.
*
* @return array[]
*/
public function test_parse_query_s_array() {
$q = new WP_Query();
$q->parse_query(
array(
's' => array( 'foo' ),
)
public function data_parse_query_s_types() {
return array(
'array input returns empty string' => array( array( 'foo' ), '' ),
'string input returns string' => array( 'foo', 'foo' ),
'float input returns float' => array( 3.5, 3.5 ),
'int input returns int' => array( 3, 3 ),
'bool input returns bool' => array( true, true ),
);

$this->assertSame( '', $q->query_vars['s'] );
}

public function test_parse_query_s_string() {
$q = new WP_Query();
$q->parse_query(
array(
's' => 'foo',
)
);

$this->assertSame( 'foo', $q->query_vars['s'] );
}

public function test_parse_query_s_float() {
$q = new WP_Query();
$q->parse_query(
array(
's' => 3.5,
)
);

$this->assertSame( 3.5, $q->query_vars['s'] );
}

public function test_parse_query_s_int() {
$q = new WP_Query();
$q->parse_query(
array(
's' => 3,
)
);

$this->assertSame( 3, $q->query_vars['s'] );
}

public function test_parse_query_s_bool() {
/**
* Tests that WP_Query::parse_query() handles various types for the 's' parameter.
*
* @ticket 29736
*
* @dataProvider data_parse_query_s_types
*
* @param mixed $input The value to pass as 's'.
* @param mixed $expected The expected value of query_vars['s'].
*/
public function test_parse_query_s_type( $input, $expected ) {
$q = new WP_Query();
$q->parse_query(
array(
's' => true,
's' => $input,
)
);

$this->assertTrue( $q->query_vars['s'] );
$this->assertSame( $expected, $q->query_vars['s'] );
}

/**
Expand Down
Loading