Skip to content

HTML API: Handle "adoption agency" any other end tag case#12229

Draft
sirreal wants to merge 7 commits into
WordPress:trunkfrom
sirreal:adoption-agency-any-other-end-tag
Draft

HTML API: Handle "adoption agency" any other end tag case#12229
sirreal wants to merge 7 commits into
WordPress:trunkfrom
sirreal:adoption-agency-any-other-end-tag

Conversation

@sirreal

@sirreal sirreal commented Jun 19, 2026

Copy link
Copy Markdown
Member

Implement adoption agency algorithm's "any other end tag" case.

This does not fully implement the remaining adoption agency algorithm support, only the "any other end tag" case. Additional support can be added separately.

Notably this supports HTML like the following, which the WordPress editor is known to produce:

<a><a></a></a>

(Correctly produces to A siblings on this branch, unsupported in 7.0)

Compared with trunk, 6 html5lib tests are now supported:

  • <b><table><td></b><i></table>X
  • <select><b><option><select><option></b></select>X (this is legacy SELECT behavior, see HTML API: Update customizable <select> parsing #9298)
  • <b>Test</i>Test
  • <b><table><td></b><i></table>
  • <select><b><option><select><option></b></select> (this is legacy SELECT behavior, see HTML API: Update customizable <select> parsing #9298)
  • </strong></b></em></i></u></strike></s></blink></tt></pre></big></small></font></select></h1></h2></h3></h4></h5></h6></body></br></a></img></title></span></style></script></table></th></td></tr></frame></area></link></param></hr></input></col></base></meta></basefont></bgsound></embed></spacer></p></dd></dt></caption></colgroup></tbody></tfoot></thead></address></blockquote></center></dir></div></dl></fieldset></listing></menu></ol></ul></li></nobr></wbr></form></button></marquee></object></html></frameset></head></iframe></image></isindex></noembed></noframes></noscript></optgroup></option></plaintext></textarea>

Trac ticket: TBD

Alternate to #6983 which adds support for all adoption agency algorithm behaviors.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude, Codex
Used for: Fuzz testing.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dmsnell

dmsnell commented Jun 19, 2026

Copy link
Copy Markdown
Member

@sirreal I like moving in_body_any_other_end_tag() to its own method; I recently encountered that in some foreign-element thing too.

would it make sense to do that in a separate PR and then update this so that it’s focused on the adoption-agency algorithm?

@sirreal

sirreal commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

I like moving in_body_any_other_end_tag() to its own method; I recently encountered that in some foreign-element thing too.

Sure, that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants