HTML API: Handle "adoption agency" any other end tag case#12229
HTML API: Handle "adoption agency" any other end tag case#12229sirreal wants to merge 7 commits into
Conversation
Simplifies return and flow, no need to leave it for caller
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@sirreal I like moving would it make sense to do that in a separate PR and then update this so that it’s focused on the adoption-agency algorithm? |
Sure, that sounds good to me. |
Implement adoption agency algorithm's "any other end tag" case.
This does not fully implement the remaining adoption agency algorithm support, only the "any other end tag" case. Additional support can be added separately.
Notably this supports HTML like the following, which the WordPress editor is known to produce:
(Correctly produces to
Asiblings on this branch, unsupported in 7.0)Compared with trunk, 6 html5lib tests are now supported:
<b><table><td></b><i></table>X<select><b><option><select><option></b></select>X(this is legacy SELECT behavior, see HTML API: Update customizable <select> parsing #9298)<b>Test</i>Test<b><table><td></b><i></table><select><b><option><select><option></b></select>(this is legacy SELECT behavior, see HTML API: Update customizable <select> parsing #9298)</strong></b></em></i></u></strike></s></blink></tt></pre></big></small></font></select></h1></h2></h3></h4></h5></h6></body></br></a></img></title></span></style></script></table></th></td></tr></frame></area></link></param></hr></input></col></base></meta></basefont></bgsound></embed></spacer></p></dd></dt></caption></colgroup></tbody></tfoot></thead></address></blockquote></center></dir></div></dl></fieldset></listing></menu></ol></ul></li></nobr></wbr></form></button></marquee></object></html></frameset></head></iframe></image></isindex></noembed></noframes></noscript></optgroup></option></plaintext></textarea>Trac ticket: TBD
Alternate to #6983 which adds support for all adoption agency algorithm behaviors.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude, Codex
Used for: Fuzz testing.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.