Skip to content

Added && ! wp_installing() to the guard around get_language_attributes() #12663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lloc wants to merge 5 commits into
base: trunk
Choose a base branch
from
+55 −0
Open

Added && ! wp_installing() to the guard around get_language_attributes() #12663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75d49a0
Added && ! wp_installing() to the guard around get_language_attributes()
lloc Jul 23, 2026
c080aa8
Cleanup
lloc Jul 23, 2026
ce0e4ce
Coderstyle corrected
lloc Jul 23, 2026
f01cf1d
Tests adjusted
lloc Jul 23, 2026
f77e183
Merge branch 'trunk' into fix/50228-wp_die-infinite-loop
lloc Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3955,9 +3955,14 @@ function _default_wp_die_handler( $message, $title = '', $args = array() ) {
/*
* If `text_direction` was not explicitly passed,
* use get_language_attributes() if available.
*
* Skipped while installing: get_language_attributes() queries the
* database, which could re-trigger the DB error that led here and
* loop wp_die() indefinitely. See #50228.
*/
if ( empty( $args['text_direction'] )
&& function_exists( 'language_attributes' ) && function_exists( 'is_rtl' )
&& ! wp_installing()
) {
$dir_attr = get_language_attributes();
}
Expand Down
50 changes: 50 additions & 0 deletions tests/phpunit/tests/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,4 +2247,54 @@ public function test_wp_recursive_ksort() {
);
$this->assertSameSetsWithIndex( $theme_json, $expected_theme_json );
}

/**
* Tests that _default_wp_die_handler() only queries the database for language
* attributes when WordPress is not installing.
*
* @ticket 50228
* @covers ::_default_wp_die_handler
* @dataProvider data_default_wp_die_handler_language_attributes
*
* @param bool $installing Whether WordPress is installing.
* @param string $expected_attr Substring the output is expected to contain.
* @param string $unexpected_attr Substring the output is expected not to contain.
*/
public function test_default_wp_die_handler_language_attributes( $installing, $expected_attr, $unexpected_attr ) {
$was_installing = wp_installing();
wp_installing( $installing );

ob_start();
_default_wp_die_handler( 'Error message', 'Error title', array( 'exit' => false ) );
$output = ob_get_clean();

wp_installing( $was_installing );

$this->assertStringContainsString( $expected_attr, $output );
$this->assertStringNotContainsString( $unexpected_attr, $output );
}

/**
* Data provider for test_default_wp_die_handler_language_attributes().
*
* @return array[] {
* @type bool $installing Whether WordPress is installing.
* @type string $expected_attr Substring the output is expected to contain.
* @type string $unexpected_attr Substring the output is expected not to contain.
* }
*/
public function data_default_wp_die_handler_language_attributes() {
return array(
'installing: falls back to the dir attribute' => array(
'installing' => true,
'expected_attr' => "<html dir='",
'unexpected_attr' => 'lang=',
),
'not installing: uses get_language_attributes()' => array(
'installing' => false,
'expected_attr' => 'lang="',
'unexpected_attr' => "dir='",
),
);
}
}
Loading