Upgrade/Install: Clean up working directory after installation failure#12676
Draft
ArkaPrabhaChowdhury wants to merge 5 commits into
Draft
Upgrade/Install: Clean up working directory after installation failure#12676ArkaPrabhaChowdhury wants to merge 5 commits into
ArkaPrabhaChowdhury wants to merge 5 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR addresses upgrade/install cleanup by ensuring the extracted working directory is removed when WP_Upgrader::install_package() fails and clear_working is enabled, and adds a regression test covering that failure path.
Changes:
- Delete the unpacked working directory in
WP_Upgrader::run()wheninstall_package()returns aWP_Errorandclear_workingis true. - Add a PHPUnit regression test to assert the working directory cleanup occurs on installation failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/wp-admin/includes/class-wp-upgrader.php | Adds working directory cleanup in WP_Upgrader::run() for the WP_Error failure path when clear_working is enabled. |
| tests/phpunit/tests/admin/wpUpgrader.php | Adds a regression test asserting run() deletes the working directory when install_package() fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+1511
to
+1517
| $actual = $instance->run( | ||
| array( | ||
| 'package' => '/tmp/test-package.zip', | ||
| 'destination' => WP_PLUGIN_DIR, | ||
| 'is_multi' => true, | ||
| ) | ||
| ); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/44710
Ensures extracted upgrade working directories are removed when package installation fails and clear_working is enabled. Adds focused regression coverage for the failure path.
Tests: phpunit tests/phpunit/tests/admin/wpUpgrader.php (108 tests, 347 assertions).