Skip to content

KSES: Allow autofocus attribute only on the dialog element.#12682

Open
afercia wants to merge 1 commit into
WordPress:trunkfrom
afercia:65491-allow-autofocus-only-on-dialog
Open

KSES: Allow autofocus attribute only on the dialog element.#12682
afercia wants to merge 1 commit into
WordPress:trunkfrom
afercia:65491-allow-autofocus-only-on-dialog

Conversation

@afercia

@afercia afercia commented Jul 24, 2026

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65491

Allows the autofocus attribute in KSES, only for the <dialog> element for now.

Use of AI Tools

None

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 24, 2026 13:17
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props afercia, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates WordPress’s KSES HTML allowlist to permit the autofocus attribute only on the <dialog> element (per Trac #65491), and adds a PHPUnit regression test to ensure autofocus is preserved on dialogs but stripped from other elements in post content.

Changes:

  • Allow autofocus on <dialog> in the default post-content KSES allowlist.
  • Add a PHPUnit test asserting autofocus is kept for <dialog> and removed for other focusable elements in wp_kses_post().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/wp-includes/kses.php Adds autofocus to the allowed attributes for the dialog tag in the post-content allowlist.
tests/phpunit/tests/kses.php Adds a regression test covering dialog-only allowance and stripping elsewhere via wp_kses_post().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afercia for the PR!

Changes look good to me.

Copilot AI review requested due to automatic review settings July 24, 2026 19:16
@afercia
afercia force-pushed the 65491-allow-autofocus-only-on-dialog branch from 2ba9f8b to b870877 Compare July 24, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@joedolson joedolson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants