KSES: Allow autofocus attribute only on the dialog element.#12682
KSES: Allow autofocus attribute only on the dialog element.#12682afercia wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
Updates WordPress’s KSES HTML allowlist to permit the autofocus attribute only on the <dialog> element (per Trac #65491), and adds a PHPUnit regression test to ensure autofocus is preserved on dialogs but stripped from other elements in post content.
Changes:
- Allow
autofocuson<dialog>in the default post-content KSES allowlist. - Add a PHPUnit test asserting
autofocusis kept for<dialog>and removed for other focusable elements inwp_kses_post().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/wp-includes/kses.php |
Adds autofocus to the allowed attributes for the dialog tag in the post-content allowlist. |
tests/phpunit/tests/kses.php |
Adds a regression test covering dialog-only allowance and stripping elsewhere via wp_kses_post(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @afercia for the PR!
Changes look good to me.
2ba9f8b to
b870877
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/65491
Allows the
autofocusattribute in KSES, only for the<dialog>element for now.Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.