Skip to content

Plugins: Display required WordPress version for incompatible plugins #12691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kipmyk wants to merge 8 commits into
base: trunk
Choose a base branch
from
+49 −2
Open

Plugins: Display required WordPress version for incompatible plugins #12691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e238ce
Robots: Use `admin_url()` for the `robots.txt` admin paths.
westonruter Jul 4, 2026
ec8b004
Site Health: Remove redundant `function_exists( 'ini_get' )` checks.
Jul 4, 2026
93b45f4
Docs: Modernize and improve specificity of types in `WP_Error` class.
westonruter Jul 5, 2026
f01bda1
Filesystem: Fix subdirectory recursion in `WP_Filesystem_Direct::chgr…
westonruter Jul 5, 2026
2252f6d
Filesystem API: Improve type safety across the transport classes.
westonruter Jul 5, 2026
fd59fee
Merge remote-tracking branch 'upstream/trunk' into trunk
kipmyk Jul 25, 2026
9153f73
Plugins: Display required WordPress version for incompatible plugins.
kipmyk Jul 25, 2026
35ffdc7
Plugins: Escape $requires_wp version in incompatibility notices.
kipmyk Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/wp-admin/includes/class-wp-plugin-install-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,15 @@ public function display_rows() {
$incompatible_notice_message .= wp_update_php_annotation( '</p><p><em>', '</em>', false );
}
} elseif ( ! $compatible_wp ) {
$incompatible_notice_message .= __( 'This plugin does not work with your version of WordPress.' );
if ( ! empty( $requires_wp ) ) {
$incompatible_notice_message .= sprintf(
/* translators: %s: Minimum required WordPress version. */
__( 'This plugin requires WordPress %s or higher.' ),
esc_html( $requires_wp )
);
} else {
$incompatible_notice_message .= __( 'This plugin does not work with your version of WordPress.' );
}
if ( current_user_can( 'update_core' ) ) {
$incompatible_notice_message .= sprintf(
/* translators: %s: URL to WordPress Updates screen. */
Expand Down
10 changes: 9 additions & 1 deletion src/wp-admin/includes/plugin-install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,15 @@ function install_plugin_information() {
)
);
} elseif ( ! $compatible_wp ) {
$compatible_wp_notice_message = __( '<strong>Error:</strong> This plugin <strong>requires a newer version of WordPress</strong>.' );
if ( ! empty( $requires_wp ) ) {
Comment thread
kipmyk marked this conversation as resolved.
$compatible_wp_notice_message = sprintf(
/* translators: %s: Minimum required WordPress version. */
__( '<strong>Error:</strong> This plugin <strong>requires WordPress %s or higher</strong>.' ),
esc_html( $requires_wp )
);
} else {
$compatible_wp_notice_message = __( '<strong>Error:</strong> This plugin <strong>requires a newer version of WordPress</strong>.' );
}
if ( current_user_can( 'update_core' ) ) {
$compatible_wp_notice_message .= sprintf(
/* translators: %s: URL to WordPress Updates screen. */
Expand Down
31 changes: 31 additions & 0 deletions tests/phpunit/tests/admin/wpPluginInstallListTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Tests_Admin_wpPluginInstallListTable extends WP_UnitTestCase {

public function set_up() {
parent::set_up();
require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
$this->table = _get_list_table( 'WP_Plugin_Install_List_Table', array( 'screen' => 'plugin-install' ) );
}

Expand All @@ -24,4 +25,34 @@ public function set_up() {
public function test_get_views_should_return_no_views_by_default() {
$this->assertSame( array(), $this->table->get_views() );
}

/**
* @ticket 61211
*
* @covers WP_Plugin_Install_List_Table::display_rows
*/
public function test_display_rows_incompatible_wp_displays_required_version() {
$this->table->items = array(
array(
'slug' => 'incompatible-test-plugin',
'name' => 'Incompatible Test Plugin',
'version' => '1.0.0',
'author' => 'Test Author',
'requires' => '99.0',
'requires_php' => '7.0',
'last_updated' => '2026-01-01 00:00:00',
'icons' => array( 'default' => 'http://example.org/icon.png' ),
'short_description' => 'A test plugin.',
'rating' => 100,
'num_ratings' => 1,
'active_installs' => 1000,
),
);

ob_start();
$this->table->display_rows();
$output = ob_get_clean();

$this->assertStringContainsString( 'This plugin requires WordPress 99.0 or higher.', $output );
}
}
Loading