Skip to content

Restore filter by date label in the media grid.#12692

Open
afercia wants to merge 1 commit into
WordPress:trunkfrom
afercia:fix-media-grid-filter-by-date-label
Open

Restore filter by date label in the media grid.#12692
afercia wants to merge 1 commit into
WordPress:trunkfrom
afercia:fix-media-grid-filter-by-date-label

Conversation

@afercia

@afercia afercia commented Jul 25, 2026

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65711

Fixes a typo that prevents the label for the 'Filter by date' select from being rendered in the Media grid.

Use of AI Tools

Nond.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 25, 2026 12:37
@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props afercia, mirmpro.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@anik-cse

Copy link
Copy Markdown

Patch tested Report

Environment

  • WordPress: 7.0.2
  • Subdirectory: No
  • PHP: 8.5.1
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 10.6.23-MariaDB / Client: mysqlnd 8.5.1)
  • Browser: Chrome 150.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Five 1.4
  • MU Plugins: None activated
  • Plugins:
    • Core Rollback 1.4.2
    • Test Reports 1.3.0

Steps taken

  1. Logged into the WordPress admin dashboard, navigated to Media > Library, and switched to the Grid view.
  2. Inspected the HTML source of the media toolbar filters to verify the presence and association of the <label for="media-attachment-date-filters">Filter by date</label> element directly preceding the <select id="media-attachment-date-filters"> dropdown.
  3. ✅ Patch is solving the problem

Expected result

  • The "Filter by date" select element in the Media Library grid view should be correctly labeled and associated via the proper ID/for attribute relationship for accessibility compliance.

Additional Notes

  • The patch resolves the missing label regression caused by the previous ID reference mapping typo (dateFilter vs dateFilterLabel), ensuring correct screen reader compatibility.

Screenshots/Screencast with results

  • N/A

Support Content

  • N/A

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants