Backport Duotone fixes for 5.9.1#2326
Closed
Mamaduka wants to merge 14 commits into
Closed
Conversation
ajlende
reviewed
Feb 16, 2022
Comment on lines
+595
to
+611
| /** | ||
| * Render the SVG filters supplied by theme.json. | ||
| * | ||
| * Note that this doesn't render the per-block user-defined | ||
| * filters which are handled by wp_render_duotone_support, | ||
| * but it should be rendered in the same location as those to satisfy | ||
| * Safari's rendering quirks. | ||
| * | ||
| * @since 5.9.0 | ||
| */ | ||
| function wp_global_styles_render_svg_filters() { | ||
| $filters = wp_get_global_styles_svg_filters(); | ||
| if ( ! empty( $filters ) ) { | ||
| echo $filters; | ||
| } | ||
| } | ||
| add_action( 'wp_body_open', 'wp_global_styles_render_svg_filters' ); |
There was a problem hiding this comment.
For some reason the SVG filters are not rendering in the post-editor for me as if wp_body_open() is not being called. It works fine when viewing the post. Testing with TwentyTwentyTwo with the following added to the theme.json.
{
"styles": {
"blocks": {
"core/image": {
"filter": {
"duotone": "var(--wp--preset--duotone--primary-and-secondary)"
}
}
}
}
}
Member
Author
There was a problem hiding this comment.
The wp_body_open is template action. I don't think it's called or should be called in Dashboard.
There was a problem hiding this comment.
Hmm. It was being called with this setup back when I wrote that code. We'll have to find a similar action that gets called in <body> before everything else, then
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Member
Author
|
@ajlende created PR on my fork that contains a much-requested feature, allowing users to disable Duotone - Mamaduka#12. |
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/52757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backporting patch for the following Gutenberg PRs:
Props @ajlende, @scruffian
Trac ticket: https://core.trac.wordpress.org/ticket/55179
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.