Update spacer block markup in patterns/templates registered by Twenty Twenty-Two and Core#2422
Open
jsnajdr wants to merge 1 commit into
Open
Update spacer block markup in patterns/templates registered by Twenty Twenty-Two and Core#2422jsnajdr wants to merge 1 commit into
jsnajdr wants to merge 1 commit into
Conversation
… Twenty-Two and Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Twenty Twenty-Two theme registers block patterns and templates that contain deprecated markup for
core/spacerblocks. They specifyheightattribute as a number ("height":50) instead of a string that includes units ("height":"50px"). Because of that, the block parser reports a lot of depreciations in browser console, like:The spacer format change was introduced in this PR: WordPress/gutenberg#36186
I'm also updating the
core/query-offset-postspattern registered by Core itself, not by a theme. And one instance ofcore/coverblock which also had deprecated markup.I'm updating only code that doesn't support WordPress versions older than 5.9, i.e., Core and the Twenty Twenty-Two theme. Other themes, like Twenty Thirteen, also register patterns with deprecated markup, but these also support older versions of WordPress, which wouldn't be able to parse the new format.
Fixes https://core.trac.wordpress.org/ticket/55410