Skip to content

Make block type aware of ancestor prop#2521

Closed
DAreRodz wants to merge 7 commits into
WordPress:trunkfrom
DAreRodz:add/block-server-ancestor
Closed

Make block type aware of ancestor prop#2521
DAreRodz wants to merge 7 commits into
WordPress:trunkfrom
DAreRodz:add/block-server-ancestor

Conversation

@DAreRodz
Copy link
Copy Markdown

@DAreRodz DAreRodz commented Apr 5, 2022

This simple PR adds support for the new ancestor property, making the WP_Block_Type class aware of it and exposing it from the block-types REST API endpoint and the get_block_editor_server_block_settings function.

The property was recently added to the block.json schema (see WordPress/gutenberg#39894).

Trac ticket: https://core.trac.wordpress.org/ticket/55531#ticket


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2022

Hi @DAreRodz! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Apr 6, 2022

@gziolo gziolo closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants