Reinstate old persistence system configuration - fixes block editor usage data#3423
Closed
talldan wants to merge 1 commit into
Closed
Conversation
Contributor
|
committed in https://core.trac.wordpress.org/changeset/54485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3253 I was a little too eager to remove the old preferences persistence configuration. This system is still used in the block editor for block inserter usage, so removing this accidentally caused the 'most used blocks' feature to stop working.
Trac ticket: https://core.trac.wordpress.org/ticket/56778
Steps to reproduce:
Prerequisite: Remove the WORDPRESS_DATA_USER_{n} local storage data (where {n} is your used id).
/inserter an notice Code is now top of the list./inserter again and noticed Code block is no longer top of the list.In trunk: The code block is no longer present at the top of the list.
In this branch: The code block should be persisted across sessions as the most used block.