Skip to content

Global styles code quality refactoring#6731

Closed
ajlende wants to merge 6 commits into
WordPress:trunkfrom
ajlende:fix/assorted-theme-json-v3-feedback
Closed

Global styles code quality refactoring#6731
ajlende wants to merge 6 commits into
WordPress:trunkfrom
ajlende:fix/assorted-theme-json-v3-feedback

Conversation

@ajlende
Copy link
Copy Markdown

@ajlende ajlende commented Jun 4, 2024

Follow-up to fix some code quality issues from #6616.

Gutenberg PR: WordPress/gutenberg#62299

Trac ticket: https://core.trac.wordpress.org/ticket/61370


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ajlende.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ajlende ajlende changed the title Update no break comments Global styles code quality refactoring Jun 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@oandregal
Copy link
Copy Markdown
Member

@oandregal oandregal closed this Jun 5, 2024
@oandregal
Copy link
Copy Markdown
Member

@ajlende Appreciate the thoroughness of creating a dedicated trac ticket for this! Given this change is a follow-up to the original ticket, for convenience, we can refer to the original ticket in the PR — no need to create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants