Fix isomorphic-git internals imports#3667
Draft
adamziel wants to merge 2 commits into
Draft
Conversation
29f356d to
a963088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Replaces the storage sparse checkout implementation with public
isomorphic-gitAPIs for ref discovery, pack indexing, and object reads. Removes the privateisomorphic-git/src/*imports, deletes the declaration shim, and avoids vendoring isomorphic-git internals.Rationale
The previous approach depended on private isomorphic-git internals and copied a large internal implementation into the storage package. Using the supported public APIs keeps this code lower-maintenance while preserving the sparse checkout behavior needed by Playground.
Implementation
listServerRefs,init,indexPack, andreadObjectfromisomorphic-git..git/indexwriter ingit-create-dotgit-directory.tsso it no longer imports privateGitIndex.withObjects: trueoutput for.gitconsumers:packfiles,objects, andfileOids.GitAuthenticationErrormapping for 401 and 403 responses.Testing
Ran: