Skip to content

CID-22607: Fixed typos in semgrep rule ignores - #259

Merged
btr-rmconsole-6[bot] merged 1 commit into
masterfrom
fixed_semgrep-rule-typo
Jul 29, 2026
Merged

CID-22607: Fixed typos in semgrep rule ignores#259
btr-rmconsole-6[bot] merged 1 commit into
masterfrom
fixed_semgrep-rule-typo

Conversation

@matthewnitschke-wk

@matthewnitschke-wk matthewnitschke-wk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

CID-22607

Issue Status

semgrep uses the format of: package_managers.pnpm.<rule_key>.<same_rule_key> for rules

#257 was using the wrong syntax, and therefore not correctly ignoring these rules

This PR fixes that

@matthewnitschke-wk
matthewnitschke-wk marked this pull request as ready for review July 29, 2026 14:46
@matthewnitschke-wk
matthewnitschke-wk requested review from a team as code owners July 29, 2026 14:46
@btr-rmconsole-6 btr-rmconsole-6 Bot changed the title Fixed typos in semgrep rule ignores CID-22607 Fixed typos in semgrep rule ignores Jul 29, 2026
@bender-wk bender-wk changed the title CID-22607 Fixed typos in semgrep rule ignores CID-22607: Fixed typos in semgrep rule ignores Jul 29, 2026

@andrewlundberg-wf andrewlundberg-wf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Workiva/release-management-pp

@rmconsole-wf rmconsole-wf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-6
btr-rmconsole-6 Bot merged commit 129797f into master Jul 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants