Skip to content

fix(theme): Bootstrap button text colour on themed pages#168

Merged
lordfolken merged 11 commits intomasterfrom
modernize/remove-jquery-replace-lightbox
Apr 9, 2026
Merged

fix(theme): Bootstrap button text colour on themed pages#168
lordfolken merged 11 commits intomasterfrom
modernize/remove-jquery-replace-lightbox

Conversation

@lordfolken
Copy link
Copy Markdown
Member

@lordfolken lordfolken commented Apr 9, 2026 •
edited by coderabbitai bot
Loading

Summary

Follow-up to merged PR #167.

The global theme rule html[class*="site-theme--"] a { color: … } has higher specificity than Bootstrap’s .btn-*, so on green-themed download pages the Download Maps button (.btn-success) showed green link text on a green background.

Change

  • In css/xcsoar-theme.css, restore Bootstrap’s --bs-btn-color, --bs-btn-hover-color, and --bs-btn-active-color for a.btn (excluding .btn-link).

Testing

  • Open a download page with color: green and confirm sidebar buttons (success, warning) have readable label colours.

Summary by CodeRabbit

  • New Features

    • Added dropdown navigation for documentation in the main navbar.
    • Enhanced homepage with expanded feature descriptions and Device integration link.

  • Documentation

    • Expanded and restructured hardware documentation with detailed platform information.
    • Updated manual navigation anchors.

  • Style

    • Improved title section spacing and visual hierarchy with border styling.
    • Enhanced button color consistency across themes.

  • Chores

    • Updated configuration formatting and automation settings.

pre-commit-ci bot and others added 11 commits April 8, 2026 23:03
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3e06e08 
for more information, see https://pre-commit.ci
@lordfolken
feat(home): lead-in for features and software libre paragraph
aa1c6d7 
- Introduce the bullet list with "Notable features include:"
- Add closing paragraph on privacy, libre software (Wikipedia), and
  linking "improve" to the developer manual on Read the Docs
@lordfolken
style(home): hero title width and spacing under tagline
6f8c5d9 
- Wrap tagline row in .container so the dotted rule matches navbar width
- Increase margin below the hero title row before main content
- Restore dotted border on .home-page-title-row where needed
- Set navbar brand mark height to 2.4em for alignment with the title line
@lordfolken
feat(nav): Docs dropdown with Manual and Hardware links
d2157ab 
- Switch Docs from a single link to a Bootstrap dropdown (mirrors Download).
- Items: Manual (/docs/#manual) and Hardware (/hardware/); omit separate Overview.
- Active state includes hardware pages (menu hardware).
@lordfolken
docs: add #manual heading id for navbar anchor
ae14465 
- Use ## Manual {#manual} so /docs/#manual matches the Docs dropdown Manual link.
@lordfolken
feat(hardware): expand supported devices and structure
fd1b3b8 
- Embedded section; driver lists aligned with XCSoar Register.cpp; varios, sensors, radios.
- Manufacturer links; OpenVario and related references; Kobo models from Model.cpp.
- Section anchors on headings; drop redundant Peripherals block; tighten NEWS blurb.
@lordfolken
chore(post): use openvario.de for OpenVario in 7.44 release notes
5fd0668
@lordfolken
feat(home): link device integration bullet to hardware page
771d2fd
@lordfolken
style: apply pretty-format-json to renovate and stylelint config
45c11ca 
Normalize JSON formatting so the pre-commit pretty-format-json hook passes.
@lordfolken
Merge branch 'master' into modernize/remove-jquery-replace-lightbox
d09b285
@lordfolken
fix(theme): restore Bootstrap button text colour on themed pages
955571c 
Theme link colour on html.site-theme--* a outranked .btn-*, so Download Maps
(btn-success) showed green text on a green button. Apply Bootstrap
--bs-btn-color and hover/active variables for .btn anchors (excluding .btn-link).
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 595b31f5-01e7-496a-8460-a02b2c9a93c9

📥 Commits

Reviewing files that changed from the base of the PR and between 344f17f and 955571c.

📒 Files selected for processing (11)
  • .stylelintrc.json
  • _data/nav.yml
  • _includes/header.html
  • _includes/nav-main-items.html
  • _posts/2026-03-22-xcsoar-7-dot-44-released.md
  • css/xcsoar-theme.css
  • css/xcsoar.css
  • docs/index.md
  • hardware/index.md
  • index.html
  • renovate.json
📝 Walkthrough

Walkthrough

This pull request updates the XCSoar website by introducing a documentation dropdown navigation menu, restructuring hardware documentation, enhancing homepage content, refining CSS styling for buttons and spacing, and reorganizing build configuration. The changes span navigation data, templates, content pages, stylesheets, and tooling configuration.

Changes

Cohort / File(s) Summary
Navigation & Templates
_data/nav.yml, _includes/nav-main-items.html, _includes/header.html		 Added docs_dropdown navigation type with conditional rendering for dropdown menu containing Manual and Hardware links. Wrapped title section in additional container div when tagline present.
Documentation Content
docs/index.md, hardware/index.md		 Added explicit anchor identifier to Manual section header. Substantially rewrote hardware documentation to include new platform descriptions, expanded device support list, reorganized sections for embedded hardware and built-in drivers, and clarified Android/Kobo subsections.
Homepage Content
index.html		 Added introductory paragraph for notable features and hyperlinked "Device integration" feature to hardware documentation page. Appended paragraph on privacy and software libre licensing.
Styling
css/xcsoar-theme.css, css/xcsoar.css		 Added theme-scoped CSS rules for button link color overrides using Bootstrap variables. Updated home page title row spacing (margin-bottom: 1.75rem) and added dotted bottom border. Increased navbar brand mark height from 1.2em to 2.4em.
Configuration & Metadata
.stylelintrc.json, _posts/2026-03-22-xcsoar-7-dot-44-released.md, renovate.json		 Reformatted stylelint ignoreFiles array. Updated OpenVario project URL from .org to .de in release post. Reorganized renovate.json with multi-line array formatting and explicit automerge flags for package rules.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 A dropdown menu hops into view,
Hardware docs bloom green and new,
CSS buttons styled just right,
Homepage shines with fresh delight,
The website dances, springtime through! 🌼

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch modernize/remove-jquery-replace-lightbox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lordfolken lordfolken merged commit 09b520a into master Apr 9, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lordfolken